Update Throws/Catch/DoesNotThrow async assertion documentation for NUnit 5#1183
Update Throws/Catch/DoesNotThrow async assertion documentation for NUnit 5#1183stevenaw wants to merge 4 commits into
Conversation
| // Negative tests | ||
| Assert.That("Hello", Is.Not.InstanceOf<int>()); | ||
| Assert.That(null, Is.Not.InstanceOf<string>()); // null is not an instance of any type | ||
| Assert.That((string?)null, Is.Not.InstanceOf<string>()); // null is not an instance of any type |
There was a problem hiding this comment.
This resolved an overload ambiguity. The compiler seemed to want to resolve to the Action overload
|
@OsirisTerje @SeanKilleen Can I ask your thoughts on merge timing of this one? It (currently) organizes these pages from an NUnit 5-first perspective, leaving previous behavior for a section later down the page. NUnit 5 should be pretty soon I think, but should we still wait to merge until after v5? |
|
@stevenaw I'm on a family vacation but will aim to provide comments tomorrow. |
|
I was thinking about the same. Normally we just add a small note when we have added something, but for this major release there are whole major sections that needs a rewrite. Option 1 is to move all current documentation into a separate folder for Version 3 and 4 documentation. That would leave a lot of documentation unchanged, and all external links in to ours would be broken, as we don't use permalinks. Alternatively move it to a separate web site. e.g. docs.v4.nunit.org. External links would always point to the new pages, so it might be hard to find. For Option two we could also add links at the top for going to V3/4, if the page is too large. PS: I like the way you written it in this PR. Not sure if it scales for everything we have to change, like https://docs.nunit.org/articles/nunit/writing-tests/assertions/assertion-models/constraint.html if we change the basic language as discussed in #5244 and #5221 PS2: Perhaps DocFX can do something for us here, I read about Multi-Docset configurations.... @SeanKilleen ? PS3: Or we could use the git versions, and mark the major version changes (tags), and publish one site per version, and only the current goes to the default doc site, the others go to subsites of that. That could be doable. |
Was hoping to get v5 out by the end of May..... oops, too soon perhaps, but early June would be nice. |
3 participants
Fixes #1180
Contributes to #1164