docs: document MaxTime's WarningTime warning threshold (NUnit 5)#1182
Merged
stevenaw merged 6 commits intoMay 29, 2026
Conversation
Copilot
AI
changed the title
[WIP] Document MaxTime's new warning threshold
docs: document MaxTime's WarningTime warning threshold (NUnit 5)
May 28, 2026
stevenaw
requested changes
May 28, 2026
Member
|
@copilot The build failure is because the snippets project is not using the latest alpha package. Please update the project to use NUnit version |
Contributor
Author
Updated the NUnit package reference to |
Downgrade NUnit package version from 5.0.0-alpha.100.9 to 5.0.0-alpha.100.7.
OsirisTerje
requested changes
May 28, 2026
stevenaw
approved these changes
May 29, 2026
Arhell
approved these changes
May 29, 2026
Arhell
approved these changes
May 29, 2026
OsirisTerje
approved these changes
May 29, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
May 29, 2026
* Initial plan * docs: document MaxTime's WarningTime warning threshold parameter (NUnit 5) * docs: address review feedback - simplify warning example and fix NUnit 5+ label * fix: update NUnit package to 5.0.0-alpha.100.9 to fix build * Downgrade NUnit package version Downgrade NUnit package version from 5.0.0-alpha.100.9 to 5.0.0-alpha.100.7. * fix: replace random sleep with constant 201ms in warning threshold example --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Steven Weerdenburg <stevenaw@users.noreply.github.com> c430ce2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NUnit 5 added a
WarningTimenamed parameter toMaxTimeAttribute(nunit/nunit#5261) — if a test exceeds the warning threshold but still completes within the failure limit, the result isWarningrather thanFailure. This was not documented.Changes
maxtime.md— Added a "Named Parameters" table forWarningTime, a "Warning Threshold" example section, and a note clarifying the soft-threshold semantics.MaxTimeAttributeExamples.cs— Added#region MaxTimeWarningThresholdsnippet referenced by the docs.