fix: do not override system shadow utilities#402
Merged
Conversation
331e328 to
ffb63ca
Compare
ffb63ca to
c079374
Compare
Previously, the shadow binaries would be available in system-manager path but without the correct setuid permissions, which could lead to security issues and functionality problems. This change ensures that the shadow binaries are not deployed in system-manager path.
c079374 to
7fb2265
Compare
Member
|
This issue is a symptom of #404 This is more a band-aid than a proper fix. But I guess it's better than nothing. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the shadow binaries would be available in system-manager path but without the correct setuid permissions, which could lead to security issues and functionality problems.
This change ensures that the shadow binaries are not deployed in system-manager path.