fix(player): shorten the default POOR BGA display window to 500ms (LR2) - #178
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
be-music-player-demo | b3fa635 | Commit Preview URL Branch Preview URL |
Aug 19 2026, 11:06 AM |
Exports Benchmark
Summary
Top Regressions
Top Improvements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140.
Real LR2 ships
<poorbga>500</poorbga>in itsconfig.xml, and its changelog documents the miss-BGA display time as "adjustable in ms (default: 500ms)". Our shared default (DEFAULT_POOR_BGA_DISPLAY_SECONDS) was 2 s — four times longer — and both the TUI compositor and the web LR2 scene inherit it.Changes
DEFAULT_POOR_BGA_DISPLAY_SECONDS:2→0.5(packages/player/src/core/bga-timeline.ts), with the LR2 provenance recorded in the doc comment.<expiry. The previous suite passed identically with either 2 s or 0.5 s, so nothing pinned the value.renderBgadoc.docs/player-spec.md/.ja.md(the POOR section previously stated no duration).@be-music/player,@be-music/player-tui,@be-music/player-web.Notes
Testing
vitest run packages/player-tui/src/bga.test.ts packages/player/src/core/bga-timeline.test.ts— 35 passed (includes the new boundary test).tsctypecheck for@be-music/player,@be-music/player-tui,@be-music/player-web;oxlintclean.🤖 Generated with Claude Code