Repository navigation
Conversation
…tes, sign-off DEVELOPING.md covers what each part needs, the repository map, the unit tests, the hardware corpus and self-tests, building the Windows and Mac apps, testing on real hardware, the rules for changes, and where to start. The new Tests workflow runs the unit tests on every pull request and on main. Issue templates ask for the report ID and the machine. CONTRIBUTING.md asks for signed-off commits (Developer Certificate of Origin). The Mac app did not build with Swift 6.4: an unowned capture of self inside a closure that captured self implicitly is now an error under -warnings-as-errors. The outer closure now captures self explicitly, which keeps the same ownership as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Nothing ran the tests on pull requests, there was no setup guide for contributors, and the Mac app did not build with Swift 6.4.
What this changes
DEVELOPING.md: what each part needs, the repository map, tests, building, testing on hardware, rules for changes, where to start..github/workflows/tests.yml: unit tests on every pull request and on main.CONTRIBUTING.md.mac/Sources/main.swift: explicit[self]capture so Swift 6.4 builds it; same ownership as before.How I tested it
Fresh clone of main: unit tests 1242 OK on Python 3.12 and 3.14; corpus fetch + build clean (every config passes ocvalidate);
mac/build.shbuilds with Swift 6.4 after the fix.