Skip to content

Developer kit: setup guide, tests on every pull request, issue templates, sign-off - #172

Merged
nullmoth merged 1 commit into
mainfrom
dev-kit
Nov 13, 2026
Merged

nullmoth merged 1 commit into
mainfrom
dev-kit

Conversation

@nullmoth

Copy link
Copy Markdown
Owner

What was wrong
Nothing ran the tests on pull requests, there was no setup guide for contributors, and the Mac app did not build with Swift 6.4.

What this changes

  • DEVELOPING.md: what each part needs, the repository map, tests, building, testing on hardware, rules for changes, where to start.
  • .github/workflows/tests.yml: unit tests on every pull request and on main.
  • Issue templates (report ID + machine), CODEOWNERS, sign-off rule in CONTRIBUTING.md.
  • mac/Sources/main.swift: explicit [self] capture so Swift 6.4 builds it; same ownership as before.

How I tested it
Fresh clone of main: unit tests 1242 OK on Python 3.12 and 3.14; corpus fetch + build clean (every config passes ocvalidate); mac/build.sh builds with Swift 6.4 after the fix.

…tes, sign-off

DEVELOPING.md covers what each part needs, the repository map, the unit tests, the hardware corpus and self-tests,
building the Windows and Mac apps, testing on real hardware, the rules for changes, and where to start.
The new Tests workflow runs the unit tests on every pull request and on main. Issue templates ask for the report
ID and the machine. CONTRIBUTING.md asks for signed-off commits (Developer Certificate of Origin).

The Mac app did not build with Swift 6.4: an unowned capture of self inside a closure that captured self implicitly
is now an error under -warnings-as-errors. The outer closure now captures self explicitly, which keeps the same
ownership as before.
@nullmoth
nullmoth merged commit acea87b into main Nov 13, 2026
1 check passed
@nullmoth
nullmoth deleted the dev-kit branch November 13, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant