Repository navigation
feat(httpclient): send API key via Backlog-API-Key header - #110
Merged
Merged
Conversation
harehare
marked this pull request as ready for review
October 14, 2026 07:00
nullberg88
approved these changes
Oct 15, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The migration is consistent across request methods, with updated assertions and no identified blocking issues.
0 open findings
What changed in this PR
Moves API-key authentication into the Backlog-API-Key header in HttpClientBacklogHttpClient, keeping credentials out of generated request URLs.
Changes:
- Removes API-key query parameters across all request methods.
- Adds the header through the shared request builder while preserving bearer-token fallback.
- Updates tests to check clean URLs and the API-key header.
| File | Description |
|---|---|
| src/test/java/com/nulabinc/backlog4j/http/httpclient/HttpClientBacklogHttpClientTest.java | Verifies URLs and authentication headers across request methods. |
| src/main/java/com/nulabinc/backlog4j/http/httpclient/HttpClientBacklogHttpClient.java | Replaces API-key query parameters with a shared authentication header. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Replace the apiKey query parameter with the Backlog-API-Key request header in HttpClientBacklogHttpClient, so the API key no longer appears in request URLs.
Verify that an access token is sent via the Authorization: Bearer header without Backlog-API-Key, and that the API key takes precedence when both an API key and an access token are configured.
harehare
force-pushed
the
feat/api-key-header
branch
from
October 16, 2026 09:34
39af0ad to
4478af4
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the apiKey query parameter with the Backlog-API-Key request header in HttpClientBacklogHttpClient, so the API key no longer appears in request URLs.