Skip to content

fix(ci): restore the nub.jsonc schema the build and release tools read - #652

Open
pullfrog[bot] wants to merge 1 commit into
mainfrom
pullfrog/650-restore-nub-jsonc-schema
Open

fix(ci): restore the nub.jsonc schema the build and release tools read#652
pullfrog[bot] wants to merge 1 commit into
mainfrom
pullfrog/650-restore-nub-jsonc-schema

Conversation

@pullfrog

@pullfrog pullfrog Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Closes #650

Diagnosis

Not #647 — that commit is innocent. The break came from 3539b65db ("site: hide the nub.jsonc config reference until it ships"), which deleted site/public/schema/latest.json and v0.6.json along with the docs page and the /schema route. Those two files are not only published assets — three internal tools read them:

Consumer Effect of the deletion
crates/nub-cli/src/project_config.rs:1930 include_str!("../../../site/public/schema/latest.json") — the nub bin's test target stops compiling
scripts/set-version.mjs:26 make version V=<v> aborts before stamping any version surface
Makefile:206 make version-check fails with missing or unreadable schema snapshot for v0.6.json

The first one is the trunk-red. Reproduced with the exact CI command on the failing SHA:

error: couldn't read `crates/nub-cli/src/../../../site/public/schema/latest.json`: No such file or directory (os error 2)
    --> crates/nub-cli/src/project_config.rs:1930:34
error: could not compile `nub-cli` (bin "nub" test) due to 1 previous error

That explains the failure shape: Check, Clippy, and all 7 Test legs red on every platform, while Format, Site build, Yarn PnP, and embed-runtime verify stayed green — those build no test target.

It reached main green because the deletion was confined to site/**, which resolves the rust paths-filter group false on a pull_request. On push: main that group is always true, so the first Rust job to run was the one on trunk.

Fix

  • Restores both schema files byte-for-byte from 4815226bb, the parent of the deletion. Everything user-visible — the /docs/config page, its nav entry and sidebar chip, the /schema index route — stays removed, so nothing is republished and reverting 3539b65db still restores the whole surface when the feature ships.
  • Adds the two site/public paths that are Rust compile inputs (schema/** and skill.md, the latter read by crates/nub-cli/src/agent/mod.rs) to the rust paths-filter group, so the next edit to either runs the Rust jobs on the PR instead of on trunk.

Verification

  • cargo check --all-targets --profile fast — the failing CI step, now exit 0.
  • cargo test -p nub-cli --bin nub published_schema_exposes_every_parser_key — passes, so the restored schema still matches the parser's ROOT_KEYS / INSTALL_KEYS / DLX_KEYS and enum value sets at this SHA.
  • make version-check — passes; confirmed as a negative control that it fails with the files moved aside.

Pullfrog  | View workflow run | via Pullfrog | Using Claude Opus𝕏

3539b65 unpublished the nub.jsonc config surface: the /docs/config
reference, its nav entry and sidebar chip, the /schema index route, and
the published JSON Schemas. Deleting the schema files also cut three
consumers that have nothing to do with publishing:

- crates/nub-cli/src/project_config.rs include_str!s latest.json to pin
  the schema against the parser's key set, so the bin's test target
  stopped compiling and every check, clippy, and test job went red.
- scripts/set-version.mjs reads it to stamp the pinned release snapshot,
  and aborts before touching any version surface when it cannot.
- make version-check compares that snapshot against latest.json.

Restores both files byte-for-byte from 4815226. Everything
user-visible stays removed, so nothing is republished and reverting
3539b65 still restores the whole surface when the feature ships.

Also adds the two site/public paths that are Rust compile inputs to the
rust paths-filter group. A change confined to site/** resolved that
group false, so the deletion ran no Rust job on its PR and the break
only surfaced on main.
@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nub Ready Ready Preview Aug 1, 2026 3:53am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI is failing on main

0 participants