fix(ci): restore the nub.jsonc schema the build and release tools read - #652
Open
pullfrog[bot] wants to merge 1 commit into
Open
fix(ci): restore the nub.jsonc schema the build and release tools read#652pullfrog[bot] wants to merge 1 commit into
pullfrog[bot] wants to merge 1 commit into
Conversation
3539b65 unpublished the nub.jsonc config surface: the /docs/config reference, its nav entry and sidebar chip, the /schema index route, and the published JSON Schemas. Deleting the schema files also cut three consumers that have nothing to do with publishing: - crates/nub-cli/src/project_config.rs include_str!s latest.json to pin the schema against the parser's key set, so the bin's test target stopped compiling and every check, clippy, and test job went red. - scripts/set-version.mjs reads it to stamp the pinned release snapshot, and aborts before touching any version surface when it cannot. - make version-check compares that snapshot against latest.json. Restores both files byte-for-byte from 4815226. Everything user-visible stays removed, so nothing is republished and reverting 3539b65 still restores the whole surface when the feature ships. Also adds the two site/public paths that are Rust compile inputs to the rust paths-filter group. A change confined to site/** resolved that group false, so the deletion ran no Rust job on its PR and the break only surfaced on main.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #650
Diagnosis
Not #647 — that commit is innocent. The break came from
3539b65db("site: hide the nub.jsonc config reference until it ships"), which deletedsite/public/schema/latest.jsonandv0.6.jsonalong with the docs page and the/schemaroute. Those two files are not only published assets — three internal tools read them:crates/nub-cli/src/project_config.rs:1930include_str!("../../../site/public/schema/latest.json")— thenubbin's test target stops compilingscripts/set-version.mjs:26make version V=<v>aborts before stamping any version surfaceMakefile:206make version-checkfails withmissing or unreadable schema snapshot for v0.6.jsonThe first one is the trunk-red. Reproduced with the exact CI command on the failing SHA:
That explains the failure shape:
Check,Clippy, and all 7Testlegs red on every platform, whileFormat,Site build,Yarn PnP, andembed-runtime verifystayed green — those build no test target.It reached
maingreen because the deletion was confined tosite/**, which resolves therustpaths-filter group false on apull_request. Onpush: mainthat group is always true, so the first Rust job to run was the one on trunk.Fix
4815226bb, the parent of the deletion. Everything user-visible — the/docs/configpage, its nav entry and sidebar chip, the/schemaindex route — stays removed, so nothing is republished and reverting3539b65dbstill restores the whole surface when the feature ships.site/publicpaths that are Rust compile inputs (schema/**andskill.md, the latter read bycrates/nub-cli/src/agent/mod.rs) to therustpaths-filter group, so the next edit to either runs the Rust jobs on the PR instead of on trunk.Verification
cargo check --all-targets --profile fast— the failing CI step, now exit 0.cargo test -p nub-cli --bin nub published_schema_exposes_every_parser_key— passes, so the restored schema still matches the parser'sROOT_KEYS/INSTALL_KEYS/DLX_KEYSand enum value sets at this SHA.make version-check— passes; confirmed as a negative control that it fails with the files moved aside.Claude Opus| 𝕏