ci(node-matrix): retry setup-node once on the smoke legs - #591
Open
pullfrog[bot] wants to merge 1 commit into
Open
ci(node-matrix): retry setup-node once on the smoke legs#591pullfrog[bot] wants to merge 1 commit into
pullfrog[bot] wants to merge 1 commit into
Conversation
The 23.x/25.x smoke legs miss the actions/node-versions manifest and provision Node by fetching nodejs.org/dist live, where setup-node retries only on 5xx (actions/setup-node#1136). A DNS/reset blip there kills the leg at the setup-node step with no diagnostic and reddens trunk on a cause unrelated to nub. Run 30401930955 failed exactly this way: only the node-23.11 smoke leg was red, and it failed at setup-node with the smoke script skipped, while node 23.6 and every other version passed. Retry setup-node once, gated on the first attempt's failure, so a single provisioning blip no longer files a trunk-red issue.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Retry
actions/setup-nodeonce on the Node matrix smoke legs, gated on the first attempt failing.Why
Issue #590 (trunk-red) tracked a
Node matrixfailure onmainat74eca57. Inspecting the run (30401930955) via the jobs API, exactly one leg was red — Smoke (node 23.11) — and it failed at theactions/setup-nodestep, with the smoke script itself skipped. Every other version passed, including the sibling node 23.6 leg.This is the documented provisioning flake, not a nub regression:
actions/node-versionsrunner manifest and provision Node by fetchingnodejs.org/distlive, wheresetup-noderetries only on 5xx (actions/setup-node#1136). A DNS/reset blip there kills the leg with no diagnostic.runtime/polyfills.cjs, its types, tests, and feature-matrix rows — nothing touching Node provisioning. A polyfill-installer throw at preload would have reddened every smoke leg at the smoke-matrix step; instead the leg never reached the script.The workflow's header comment references a
setup-noderetry, but the smoke job had a single plainsetup-nodestep with no retry. This adds it: first attemptcontinue-on-error, second attempt gated on the first's failure — so a single provisioning blip no longer files a trunk-red issue.Scoped to the smoke job; the real-apps matrix (22.16/24.11/24.12/26) does not include the manifest-miss 23.x/25.x band, so it is left unchanged.
Closes #590
Claude Opus｜ 𝕏