Implements bracket-balance checks and parse speed improvements.#10
Open
ZackPierce wants to merge 2 commits into
Open
Implements bracket-balance checks and parse speed improvements.#10ZackPierce wants to merge 2 commits into
ZackPierce wants to merge 2 commits into
Conversation
…dding more tests for ParseHex.
… when parsing strings. Direct text scanning approach also significantly improves parse speed and removes an unnecessary array allocation and copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw the lone "FIXME" comment and could not resist trying to help.
The approach I ended up using is a direct search through the input string rather than a more complicated regular expression.
ParseHexis now several times faster as a result, and no longer requires the extra array creation and copy that was caused byhex.DecodeString.Using a directly-coded search has also allowed the error messages to become slightly more descriptive.
Tests have been added to confirm the functionality.