waveform decoding sets sampling size to zero if below 1 - #79
Merged
jwaiton merged 6 commits intoJun 23, 2026
Merged
Conversation
Member
|
The tests no longer pass, it will be worth understanding why this is before this PR can be accepted. Also, we don't include merge commits in MULE, we'll resolve that with a rebase :) |
Member
|
Tests pass, and the data looks untransformed (other than sampling size now being a float). Next time you're in the office, we'll rebase your code to remove the merge commits and then I'll approve it. |
Tedsmith100
force-pushed
the
74-waveform-decoding-sets-sampling-size-to-zero-if-below-1
branch
from
May 11, 2026 15:41
bb2af84 to
6209d87
Compare
Change `sample_size` to allow for floats.
'sampling_period' from int to float
change `sampling_period` to float
float `sampling_period`
rathern than asserting equals for float values
Tedsmith100
force-pushed
the
74-waveform-decoding-sets-sampling-size-to-zero-if-below-1
branch
from
June 22, 2026 13:07
e804467 to
d614051
Compare
jwaiton
approved these changes
Jun 23, 2026
jwaiton
left a comment
jwaiton
left a comment
Member
There was a problem hiding this comment.
This PR alters the sampling size to a float. This was mostly done to avoid implicit flooring of values below 1, but also now allows for more complex sampling sizes to be collected.
Good work!
jwaiton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes sample size types from int to float to accommodate non integer sampling. For example when the oscilloscope is used, the sample size is not fixed at 2ns and could be floats.