Add cacheSingleOpenCourseData helper and tests; use it in batch fetch#19
Add cacheSingleOpenCourseData helper and tests; use it in batch fetch#19
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
Description
cacheSingleOpenCourseDatainsrc/course-management/services/api/DialogMenuSearch/dataService.tsthat writes a single course into theopenCoursescache and updates the in-memoryopenCoursesCache, while warning and returning early when the hash key is missing.batchFetchCoursesDatawith calls tocacheSingleOpenCourseDatato centralize behavior and remove duplication.src/course-management/services/api/DialogMenuSearch/dataService.test.tsthat include achromestorage mock and validate both successful cache writes and the skip behavior when a hash key is missing.Testing
node --test src/course-management/services/api/DialogMenuSearch/dataService.test.ts, and both tests passed.getGenericCachereturns the storedcombinedDatamatching the JSON-serialized course and that missing hash keys produce no cache writes.Codex Task