feat: auto-cleanup visual tracer overlays on page navigation#31
Open
feat: auto-cleanup visual tracer overlays on page navigation#31
Conversation
Add attachAutoCleanup(page) method that listens to framenavigated events and removes stale overlays, preventing visual artifacts when pages navigate while overlays are visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual tracer overlays (click highlights, scroll indicators, etc.) persist across page navigations because they're removed by timeouts that get cancelled when the page unloads. This leaves stale overlay elements or causes visual artifacts on the new page.
Fix
Added
attachAutoCleanup(page)method that listens toframenavigatedevents and automatically callsclearOverlays():Returns a cleanup function to remove the listener when the tracer is no longer needed.
Test plan
bun run build— compiles cleanbun run test— all 364 tests pass