fix: replace bare Error throws with domain-specific error classes#24
Open
fix: replace bare Error throws with domain-specific error classes#24
Error throws with domain-specific error classes#24Conversation
Add SandboxError and BridgeError classes, and replace all 15 bare throw new Error() calls in production code with the appropriate custom error type for better error handling downstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all 15 bare
throw new Error()calls in production source code with domain-specific error classes, enabling callers to catch and handle specific failure types.New error classes
SandboxError— file system access violations (path traversal, file not found, read-only, size limits)BridgeError— MCP bridge failures (unknown resources, tool call errors)Changes by file
sandbox/file-access.tsSandboxErrorviewport/viewport.tsViewportErrorviewport/event-hub.tsViewportErrorcommands/extraction/extractor.tsPageExtractionErrorbridge/server.tsBridgeErrorbridge/client.tsBridgeErroragent/instructions.tsAgentErroragent/replay-recorder.tsOpenBrowserErrorBefore / After
What was NOT changed
new Error()to simulate failuresTest plan
bun run build— all 3 packages compile cleanbun run test— all 364 tests passthrow new Error()remaining in production code