GymLog: tier PR border by overall / phase / rep#1
Draft
nt1998 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the in-workout PR highlight into three colour-coded tiers without changing layout. The PR-info bar and the highlighted work-set row now read at a glance:
The previous code only had a 2-state distinction (weight PR / rep PR), both compared against the all-time best.
Changes
src/tabs/GymLog.jsx—getExercisePRnow returns{ overall, phase }buckets, walked once over committed workouts prior to the current date. Phase scope is the open phase (!p.end); falls back to all-time when no phase is open. Derives a singleprTier('overall' | 'phase' | 'rep' | null) from today's best work set vs both buckets.src/App.jsx— passesphasesinto<GymLog>.src/App.css— adds--acc-red-bg+--acc-green-bg-grad, renames the PR classes (new-overall-pr/new-phase-pr/new-rep-prandset-row.overall-pr/.phase-pr/.rep-pr), and maps each to its accent colour. Existing layout / sizes untouched.Test plan
Generated by Claude Code