Surface a clear error when pixlet is not installed#4
Open
jwjordan wants to merge 1 commit into
Open
Conversation
Tidbyt/Tronbyt pushes require the pixlet CLI to render the .star layout into a webp — including the Tronbyt direct-HTTP path. When pixlet is missing, runPixlet() bailed out before rendering and the push silently failed, surfacing only a generic "Tidbyt push failed" (menu) or "Push failed — check token, device ID, and server URL" (Settings). That gives no hint that the real problem is a missing dependency. - Extract pixlet path resolution into TidbytManager.pixletPath / isPixletInstalled (de-duplicates the candidate-path lookup). - Menu bar: show "pixlet not installed — see github.com/tidbyt/pixlet" when a push fails and pixlet is absent. - Settings: show the brew install command on a failed push, and a proactive warning row in the Tidbyt section when pixlet is missing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A push to a Tidbyt/Tronbyt device requires the
pixletCLI to render the.starlayout into a webp — and this is true even for the Tronbyt direct-HTTP push path, since that path still renders locally before POSTing the image. Whenpixletisn't installed,TidbytManager.runPixlet()returnsfalsebefore rendering, so the push silently fails and the user only sees a generic message:Tidbyt push failedPush failed — check token, device ID, and server URLNeither hints that the actual cause is a missing dependency. I hit this with a correctly-configured Tronbyt server (
device ID, server URL, and token all set) — pushes failed with no actionable signal until I traced it topixletnot being on the machine. Oncepixletwas installed, the exact render→POST chain succeeded (HTTP 200 "WebP received.") with no other changes.Changes
TidbytManager.pixletPath/isPixletInstalled, de-duplicating the candidate-path lookup that previously lived inline inrunPixlet().pixletis absent, showpixlet not installed — see github.com/tidbyt/pixletinstead of the generic error.brew installcommand, and add a proactive warning row in the Tidbyt section wheneverpixletis missing (mirrors the existing OAuth status-row pattern).No behavior change when
pixletis installed.Testing
xcodebuild ... buildsucceeds.xcodebuild ... test— existingClaudiusTestssuite passes (** TEST SUCCEEDED **).🤖 Generated with Claude Code