Use MIT SPDX license identifier in Nuget metadata#84
Open
tsondergaard wants to merge 1 commit intonreco:masterfrom
Open
Use MIT SPDX license identifier in Nuget metadata#84tsondergaard wants to merge 1 commit intonreco:masterfrom
tsondergaard wants to merge 1 commit intonreco:masterfrom
Conversation
licenseUrl is deprecated in the nuget spec. Using an SPDX identifier for the license is the recommended approach. https://learn.microsoft.com/en-us/nuget/reference/nuspec#licenseurl https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#packing-a-license-expression-or-a-license-file This is of practical importance for downstream projects that use automatic tools to inspect and document licenses. This is the "licenses" element that dotnet-CycloneDX currently generates for NReco.Logging: "licenses": [ { "license": { "name": "Unknown - See URL", "url": "https://raw.githubusercontent.com/nreco/logging/master/LICENSE" } } ] With this commit it becomes simply: "licenses": [ { "license": { "id": "MIT" } } ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
licenseUrl is deprecated in the nuget spec. Using an SPDX identifier for the license is the recommended approach.
https://learn.microsoft.com/en-us/nuget/reference/nuspec#licenseurl
https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#packing-a-license-expression-or-a-license-file
This is of practical importance for downstream projects that use automatic tools to inspect and document licenses. This is the "licenses" element that dotnet-CycloneDX currently generates for NReco.Logging:
With this commit it becomes simply: