Skip to content

Polish local shelf links and missing-shelf states#58

Merged
poketonova merged 1 commit into
mainfrom
feat/shelf-link-polish
Jul 19, 2026
Merged

Polish local shelf links and missing-shelf states#58
poketonova merged 1 commit into
mainfrom
feat/shelf-link-polish

Conversation

@poketonova

Copy link
Copy Markdown
Collaborator

Summary

  • add init-gated loading and explicit “Shelf not found” states for /portfolio/:id and /shelf/:id
  • add desktop and mobile Copy link actions using an absolute /shelf/:id URL
  • explain that shelf links are local to browsers that already contain the data and point cross-device users to Export or Local Sync
  • provide visible readonly fallback when clipboard access is unavailable or denied
  • isolate shelf setup and price refresh by captured route identity across A→B transitions
  • prevent missing shelf ids from triggering set metadata or price API work
  • harden the shelf alias redirect through named route params

Safety

  • no IndexedDB, store schema, backup, or import changes
  • in-flight refreshes write only to their captured shelf id
  • stale view instances cannot start destination-shelf setup
  • $0 remains valid in alert price checks

Verification

  • npm run eval:harness
  • npm run eval:danger
  • npm run build
  • npm run smoke:browser
  • git diff --check

Browser smoke covers both missing-shelf route shapes, 280px layout, hard-loading a valid seeded shelf, and A→B navigation during the route transition.

Privacy note

This is a same-device bookmark/deep-link feature, not public shelf hosting. No shelf contents are uploaded or encoded in the URL.

@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pokemon-collectr Ready Ready Preview, Comment Jul 19, 2026 1:02am

@poketonova
poketonova merged commit c2dfee4 into main Jul 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant