Skip to content

Track exact PriceCharting slab grades#57

Merged
poketonova merged 2 commits into
mainfrom
fix/full-graded-pricecharting
Jul 19, 2026
Merged

Track exact PriceCharting slab grades#57
poketonova merged 2 commits into
mainfrom
fix/full-graded-pricecharting

Conversation

@poketonova

Copy link
Copy Markdown
Collaborator

Summary

  • resolve exact graded PriceCharting products through the existing strict identity matcher, then load the complete public grade guide through a constrained same-origin endpoint
  • track Grade 1–9.5 exactly and keep PSA/BGS/CGC/SGC/ACE/TAG 10, BGS Black, and CGC Pristine as distinct price tiers
  • stop substituting PSA 10 or Grade 9 for other companies/grades, and preserve missing graded prices as unknown instead of manufacturing a tracked $0
  • add focused JavaScript and Python regression coverage for exact tier mapping and full-guide parsing

Live verification

Validated against PriceCharting product 11747998 (Ahri Signature): Grade 9.5, PSA 10, BGS 10, CGC 10, SGC 10, ACE 10, BGS Black, and CGC Pristine all parsed as distinct values; missing Grade 9 remained unavailable.

Verification

  • npm run eval:harness
  • npm run eval:danger
  • Node 22 production build
  • git diff --check
  • npm run smoke:browser attempted; skipped locally because Chrome is unavailable (CI installs Chromium)

@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pokemon-collectr Ready Ready Preview, Comment Jul 19, 2026 12:14am

@poketonova
poketonova merged commit b015aa3 into main Jul 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant