chore: Phase 1 cleanups (registry, timeouts, docs, indicator, alerts)#51
Merged
Conversation
…lerts) - cardCache: derive game list from TCGS registry instead of hardcoded array - priceCharting: 10s fetch timeouts + bad_key handling on product endpoint - priceCharting: JSDoc for extractPrice - CardLoadIndicator: reuse speed computed in timeLeft; add isLight() helper - Settings: Clear All Alerts button with confirm guard
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean maintainer-owned reimplementation of five accepted bot PRs, branched from current
main. Supersedes bot PRs #45, #43, #41, #42, #17 (do not merge those branches directly).getCardCounts()from theTCGSregistry instead of a hardcoded array — single source of truth, matches the provider-drift rule in AGENTS.md. Verified the registry ids are identical to the old hardcoded list (pokemon, mtg, lorcana, one-piece, riftbound, yugioh).AbortSignal.timeouton bothsearchPCProductsandgetPCProduct, plusbad_keyhandling on the product endpoint. Matches AGENTS.md "use timeouts".extractPrice(types + return contract). Comment-only change.timeLeftreuses the existingspeedcomputed (verified equivalent to the inlined math) and addsisLight()helper inutils/theme.js.confirm()guard;clearAllAlerts()was already imported and exists inutils/alerts.js.Verification (per AGENTS.md)
eval:harness— ✅ all harness evals passedeval:danger— ✅ tripwire fires only on expected files (priceCharting.js,cardCache.js); focused review donebuild— ✅ built clean (Node 22; Node 18 cannot run Vite 8 locally, unrelated to this change)Notes
src/services/priceCharting.js(price parser path — timeouts only, no parsing logic changed;$0-is-valid semantics untouched),src/services/tcg/cardCache.js(counts only).smoke:browserrecommended before merge if you want the full pass.🤖 Reimplemented by opencode from reviewed bot PRs