Skip to content

Enhance 'More' sheet with Share and Terms & Privacy links#35

Closed
poketonova wants to merge 1 commit into
mainfrom
dev-agent-improvement-2026-06-18
Closed

Enhance 'More' sheet with Share and Terms & Privacy links#35
poketonova wants to merge 1 commit into
mainfrom
dev-agent-improvement-2026-06-18

Conversation

@poketonova

Copy link
Copy Markdown
Collaborator

This pull request introduces two useful additions to the "More" sheet in App.vue:

  1. Share Rarebox: A new action that leverages the Web Share API (where supported) to allow users to easily share the Rarebox URL with friends or on social media. This is a common pattern for mobile-first PWAs and helps with discoverability.
  2. Terms & Privacy Link: Added a direct link to the Terms & Conditions page within the "More" sheet. Previously, this was only accessible via the footer, which could be cumbersome to reach on long pages on mobile. This improves accessibility and transparency regarding the app's privacy stance.

These changes enhance the user experience by making key actions more accessible on mobile and foldable devices.

Verification:

  • Added "Share Rarebox" item with conditional rendering based on navigator.share support.
  • Added "Terms & Privacy" item with appropriate icon and link.
  • Verified layout and spacing in the "More" sheet.
  • Branch name: dev-agent-improvement-2026-06-18

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pokemon-collectr Ready Ready Preview, Comment Jun 18, 2026 3:03pm

poketonova added a commit that referenced this pull request Jul 18, 2026
… fetch (#53)

- Dashboard: New Releases section (latest 4 Pokémon sets, newest-first
  from the cached getSets feed) with a Pokémon scope label and honest
  loading copy. Cards deep-link to /sets/pokemon?set=<id>, which
  SetsView now honors by opening the set directly — the bot PR linked
  to /sets?set=<id>, a query param nothing consumed (from #49)
- More sheet: Share Rarebox (Web Share API, collector-voice copy) and
  Terms & Privacy link (from #35, with copy tweak)
- AddItemModal: PriceCharting price fetch for graded Pokémon cards,
  with full fetchPrice error mapping and grade-change invalidation.
  Scoped to Pokémon so non-Pokémon graded items keep the existing
  generic section instead of getting duplicate search/value inputs;
  single always-visible value input, editable after Apply (from #44)

Co-authored-by: novaoc <novaoc@users.noreply.github.com>
@poketonova

Copy link
Copy Markdown
Collaborator Author

Superseded by #53 (merged), which reimplements this change cleanly from current main (with the fixes noted in review). Closing.

@poketonova poketonova closed this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant