feat: Improve graded card pricing for non-Pokémon TCGs#15
Open
poketonova wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automated contribution improves the pricing accuracy for non-Pokémon graded cards in the "Add to Portfolio" modal.
Changes:
priceFeedService.js: Now captures all three PriceCharting price points (ungraded,grade9,grade10) instead of just the base price.AddItemModal.vue: Added reactive logic to update thecurrentValuefield when a user selects a "Graded Slab" for non-Pokémon TCGs. It now correctly maps the selected grade (10, 9, 9.5, etc.) to the corresponding PriceCharting data point.Pro Value:
Users tracking Magic: The Gathering, Yu-Gi-Oh!, Lorcana, and other supported TCGs will now see accurate market values for their graded slabs immediately upon selection in the Add Modal, rather than having the value default to the raw card price. This significantly reduces manual data entry and improves the portfolio valuation accuracy for collectors of these games.