Fix UTF-8 and URL-encoded static file handling in Controller#381
Open
apapacy wants to merge 2 commits into
Open
Fix UTF-8 and URL-encoded static file handling in Controller#381apapacy wants to merge 2 commits into
apapacy wants to merge 2 commits into
Conversation
Taure
requested changes
May 10, 2026
Collaborator
Taure
left a comment
There was a problem hiding this comment.
Thank you for your PR.
I will look more into it, but first look I could see a security issue. the url decoding could make %2E%2E and that .. and we accidently can escape priv directory. I see that our nova_router doesn't have url decode and I will have a look at it and we maybe can solve it before we reach the controller and in that case we don't need that part.
Author
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request: Fix UTF-8 and URL-encoded static file handling in Controller
Description
This PR addresses an issue where the Controller module failed to correctly process static files with UTF-8 characters or URL-encoded names. Previously, requesting files with special characters or non-ASCII names resulted in
404 Not Founderrors or incorrect file resolution.Changes
How to test
тест файл.pngorcafé.jpg).200 OKstatus.Короткий варіант (якщо потрібен лише опис одним абзацом):