Skip to content

Release v1.42.5 - #998

Merged
hitalin merged 4 commits into
mainfrom
develop
Aug 6, 2026
Merged

Release v1.42.5#998
hitalin merged 4 commits into
mainfrom
develop

Conversation

@hitalin

@hitalin hitalin commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

変更内容

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added clearer icons for Yami, Hana, and custom note modes.
    • Added consistent fallback icons for unknown modes.
    • Updated note and post composer mode indicators to use a unified icon style.
  • Bug Fixes

    • Improved visibility and badge icon consistency across notes and custom timelines.
    • Ensured the self-XSS warning remains visible in production builds.
  • Documentation

    • Added direct links to MisStore submission procedures and format references.
  • Chores

    • Updated the application version to 1.42.5.

hitalin and others added 3 commits August 6, 2026 23:51
vite の minify は dropConsole を有効にしているため (#985)、`console.log(...)`
と静的に判定できる呼び出しは本番ビルドで丸ごと削除される。警告は全行が
console.log なので関数ごと空になり、文言も dist から消えていた。PROD のみで
呼んでいる都合上 dev では正常に出るので、開発中は気づけない。

参照を経由して呼ぶことで DCE を回避する。同じ壊れ方を無言で再発させないため、
出力に文言が残っているかを check-dist-budget.mjs (CI の pnpm check:dist) で
検査する。壊れた形に戻すと実際に落ちることを確認済み。

Co-Authored-By: Claude <Opus 5> <noreply@anthropic.com>
モードアイコンの引き当てがカスタム TL の型名 (`hanami`) を鍵にしていたため、
モード名 (`hana`) では引けず、はなみすきーだけデフォルトの丸に落ちていた。
`isIn<X>Mode` と `isNoteIn<X>Mode` の両方から同じモード名を取り出し、
アカウントのモードとノートのモードを 1 つの表で引くようにする。

アイコンはフォーク本家に合わせる。yamisskey は `ti-moon` / `ti-moon-off`、
はなみすきーは独自グリフ `ti-hanamisskey-hanamode` (花) と `ti-users-group`。
独自グリフは配布フォントに無いので Tabler の花で代替し、オフ側はトグルとして
読めることを優先して `flower-off` で対にした。

未知のモードのフォールバックは用途で分ける。トグルは従来どおり toggle-左右、
ノートのバッジはトグルに見えない中立な印 (`circle-dot`) にする。

ついでにモードだけ手書き SVG path だったのをやめて Tabler クラスに統一する。
同じ行に並ぶ他のアイコンは既に `ti-*` で、描画も MkNote は fill・MkPostForm は
stroke と不揃いだった。オン/オフで別アイコンを出せるようになったので、
投稿フォームのボタンは色だけでなく形でも状態がわかる。

Co-Authored-By: Claude <Opus 5> <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 33af592f-bc04-415e-8dea-9c91db21d965

📥 Commits

Reviewing files that changed from the base of the PR and between f8b70d5 and 97b3783.

📒 Files selected for processing (7)
  • SKILLS.md
  • site/docs/dev/index.md
  • site/docs/dev/plugin.md
  • site/docs/dev/query.md
  • site/docs/dev/skill.md
  • site/docs/dev/theme.md
  • site/docs/dev/widget.md

📝 Walkthrough

Walkthrough

The release updates mode icon resolution and its consumers, adds coverage for mode mappings, preserves the self-XSS warning during distribution builds, improves distribution checks, updates distribution documentation links, and increments release metadata to 1.42.5.

Changes

Mode icons and release validation

Layer / File(s) Summary
Mode icon resolution and coverage
src/utils/customTimelines.ts, src/utils/customTimelines.test.ts
Mode parsing and icon mappings now support Yami, Hana, note-level modes, and fallback icons.
Mode icon consumers
src/composables/usePostFormState.ts, src/composables/usePostFormState.test.ts, src/utils/noteViewModel.ts, src/utils/noteViewModel.test.ts, src/components/common/MkNote.vue, src/components/common/MkPostForm.vue
Shared mode icon helpers and icon-font elements replace local SVG and icon lookup logic.
Self-XSS distribution validation
src/utils/selfXssWarning.ts, scripts/check-dist-budget.mjs
The warning uses a bound logging reference. The distribution checker verifies that the warning text remains in the entry static dependency closure.
Distribution documentation links
SKILLS.md, site/docs/dev/*.md
Documentation now links to MisStore submission instructions and registry format references.
Release version alignment
package.json, src-tauri/Cargo.toml, src-tauri/openapi.json, src-tauri/tauri.conf.json
Release metadata changes from version 1.42.4 to 1.42.5.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: 📖Doc, javascript

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lists the main changes but omits the required Why and Test sections and does not follow the template headings. Add the Why and Test sections, record test results, and add the Screenshots section because the pull request includes UI changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 72.73% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the release and version, which matches the primary changes in the pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploying notedeck with  Cloudflare Pages  Cloudflare Pages

Latest commit: 97b3783
Status: ✅  Deploy successful!
Preview URL: https://140bf015.notedeck-d3a.pages.dev
Branch Preview URL: https://develop.notedeck-d3a.pages.dev

View logs

@hitalin hitalin self-assigned this Aug 6, 2026
開発者ドキュメントが「MisStore で配布できます」と書きながらストアのトップに
しか飛ばしておらず、提出手順に辿り着けなかった。misstore 側のドキュメントが
公開されたので、各 dev ガイドから CONTRIBUTING と種別ごとの書式リファレンスへ
リンクする。SKILLS.md の「近日公開予定」も実リンクに差し替え。

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@hitalin
hitalin merged commit 5b59b67 into main Aug 6, 2026
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant