Skip to content

fix(plugins): Plugin Smith のコマンド id からコロンを除く - #39

Merged
hitalin merged 1 commit into
mainfrom
fix/plugin-smith-command-id
Aug 11, 2026
Merged

fix(plugins): Plugin Smith のコマンド id からコロンを除く#39
hitalin merged 1 commit into
mainfrom
fix/plugin-smith-command-id

Conversation

@hitalin

@hitalin hitalin commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

なぜ

Plugin Smith を起動すると読み込み時にエラーで落ちていた。

registration name "plugin-smith:run" must not contain ":"
  at <root> (Line 139, Column 20)

NoteDeck の Nd:register_command は登録名にコロンを許可していない。レジストリ内で Nd:register_command を使うのは Plugin Smith だけ(他は Plugin:register_note_action 等)なので、この 1 件だけが規約から外れていた。

変更

  • 'plugin-smith:run''plugin-smith-run'
  • 生成プロンプトの NoteDeck 規約に「id に : は使えない (英数字とハイフンのみ)」を追記。Plugin Smith は他プラグインを生成するので、同じ地雷を再生産しないようにする
  • scripts/build-registry.jsapi.json / plugins.json の sha512 を再生成

確認

  • registry ビルドは通る
  • AiScript ランタイム上での実動作は未確認(NoteDeck 側での読み込み確認が必要)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Plugin Smith now generates command IDs using only letters, numbers, and hyphens.
    • Updated the registered Plugin Smith command ID to plugin-smith-run.
  • Updates

    • Refreshed registry timestamps and Plugin Smith’s verification checksum.
    • Category totals remain unchanged.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@hitalin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3fd2aec7-5eaf-4ccd-b9c8-8a1c339d2dd2

📥 Commits

Reviewing files that changed from the base of the PR and between 69ca109 and 76573a1.

📒 Files selected for processing (2)
  • public/registry/index.json
  • public/registry/plugins.json
📝 Walkthrough

Walkthrough

Plugin Smith now generates and registers command IDs with alphanumeric characters and hyphens. Registry timestamps and the plugin checksum were updated.

Changes

Plugin Smith update

Layer / File(s) Summary
Plugin command ID contract
public/registry/plugins/plugin-smith/api.json, public/registry/plugins/plugin-smith/plugin.is
Generation rules prohibit colons in command IDs. The registered command ID changed from plugin-smith:run to plugin-smith-run.
Registry publication metadata
public/registry/index.json, public/registry/plugins.json
Top-level and category timestamps were updated. The plugin-smith SHA-512 checksum was replaced.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed タイトルは Plugin Smith のコマンド ID からコロンを除く主な変更を明確に要約しています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch fix/plugin-smith-command-id
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/plugin-smith-command-id

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 11, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
misstore 76573a1 Aug 11 2026, 04:15 AM

NoteDeck の Nd:register_command は登録名にコロンを許可しておらず、
'plugin-smith:run' はプラグイン読み込み時に
`registration name "plugin-smith:run" must not contain ":"` で弾かれていた。

id を 'plugin-smith-run' に変更し、生成プロンプトの規約にも
「id に : は使えない」を明記して、Plugin Smith が生成する
プラグインが同じエラーを再生産しないようにした。

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hitalin
hitalin force-pushed the fix/plugin-smith-command-id branch from 69ca109 to 76573a1 Compare August 11, 2026 04:15
@hitalin
hitalin merged commit 8660b24 into main Aug 11, 2026
5 checks passed
@hitalin
hitalin deleted the fix/plugin-smith-command-id branch August 11, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant