Skip to content

Static rendering improvement 2 #69

Description

@trungleduc

I've been testing and it works great for me. I have a few comments:
-It appears that when you click 'Save Cache', static rendering is automatically turned on next time you open the notebook. Wouldn't it be better to have a toggle between static rendering and kernel rendering because users may want to save cache but keep using the kernel?
-I agree with @martinRenou that we should have a warning if our notebook contains interactive widgets. We could have a confirmation dialog when selecting 'render statically' (or 'Save cache' as it is now) or we could also simply have a warning in the specta menu (maybe a little '?' icon to the right of 'Static rendering: On/Off').

Originally posted by @Yahiewi in #67 (review)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions