Add the abillity to change save strategy from auto save to selectable#123
Open
K0IN wants to merge 8 commits intonotea-org:mainfrom
Open
Add the abillity to change save strategy from auto save to selectable#123K0IN wants to merge 8 commits intonotea-org:mainfrom
K0IN wants to merge 8 commits intonotea-org:mainfrom
Conversation
* Added Settings entry * Added Editor callback for save status * Added Effect to handle routing and exiting with a warning
* Removed debug statements
Author
|
One issue to discuss, how to do it on mobile |
Collaborator
Add a save button |
* Added save icon * Added button for mobil devices * Refactored saving
Author
i added one in the top bar is this fine for you? |
|
The (mobile) save button, does it remain disabled and greyed out, when there are no changes, and turn white and clickable, when changes are present? This seems like a useful addition to be considered for a merge, if by default it doesn't change anything for existing users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this pr it is possible to change the save mode.
This helps since I sometimes open notes and edit them by accident . Until we have proper note versioning, this is a good solution to not accidentally delete / modify content of notes.
to Auto save(every change) or Explicit (when ctrl + s is pressed)
Also on pending changes, the browser will warn you for unsaved changes, same on close.
And there now is a little indicator for changes on the current document
