Skip to content

Fixing the plugin system#3

Open
yanatan16 wants to merge 1 commit intomasterfrom
plugin-overhaul
Open

Fixing the plugin system#3
yanatan16 wants to merge 1 commit intomasterfrom
plugin-overhaul

Conversation

@yanatan16
Copy link
Copy Markdown
Member

A proposal. See #1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE will explode here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE9+ should be fine. There are shims for IE8: see the reactive-ie8-shims.
We haven't changed the name yet
On Mar 16, 2015 9:26 PM, "Stephen Mathieson" notifications@github.com
wrote:

In lib/index.js
#3 (comment):

@@ -288,24 +294,18 @@ Reactive.prototype._bind = function() {
Reactive.prototype.bind = function(name, fn) {
var self = this;
if ('object' == typeof name) {

  • for (var key in name) {
  •  this.bind(key, name[key]);
    
  • }
  • return;
  • Object.keys(name).forEach(function (key) {

IE will explode here

Reply to this email directly or view it on GitHub
https://github.com/notacatjs/dommit/pull/3/files#r26547051.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants