Conversation
TheAwiteb
reviewed
Sep 15, 2026
|
|
||
| /// Set the relay URL expected in NIP-42 authentication events. | ||
| /// | ||
| /// This is useful when the local relay is embedded behind another |
Member
There was a problem hiding this comment.
I would removed this extra 3 lines, I don't see them useful
Author
There was a problem hiding this comment.
Removed and fixed the cargo fmt issue from CI 👍
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the nip42 authentication now also checks the
relaytag and defaults toself.url().await, this means it validates against the internal URL of the relay, instead of the public-facing URL.This is fine for tests, but problematic for all other use-cases.
This PR adds an optional
relay_urltoLocalRelayBuilderNip42, which lets the user override this behaviour, so the validation is against their defined public URL.Checklist
CHANGELOG.md(if applicable)