Skip to content

nostr: add pay and receive methods for BIP321 support - #1465

Open
daywalker90 wants to merge 1 commit into
nostrdevkit:masterfrom
daywalker90:nip47-bip321
Open

daywalker90 wants to merge 1 commit into
nostrdevkit:masterfrom
daywalker90:nip47-bip321

Conversation

@daywalker90

Copy link
Copy Markdown
Contributor

Description

Implements the nip47 extension NWC-321 according to https://github.com/nostr-wallet-connect/nwc/blob/main/321.md

Notes to the reviewers

They stripped nip47 down to the minimum and moved the rest to extensions here: https://github.com/nostr-wallet-connect/nwc

Checklist

  • I followed the contribution guidelines
  • I updated the relevant CHANGELOG.md (if applicable)
  • I understand and can explain all code in this PR

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
nostr/src/nips/nip47.rs 0.00% 34 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread nostr/CHANGELOG.md Outdated
Comment thread nostr/src/nips/nip47.rs
Comment thread nostr/src/nips/nip47.rs
Comment thread nostr/src/nips/nip47.rs
Comment thread nostr/src/nips/nip47.rs
Comment thread nostr/src/nips/nip47.rs Outdated
@daywalker90

Copy link
Copy Markdown
Contributor Author

Thank you for your review. Should all be fixed.

@TheAwiteb TheAwiteb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants