Skip to content

sdk(local_relay): limit the max connection limit - #1462

Closed
TheAwiteb wants to merge 1 commit into
nostrdevkit:masterfrom
TheAwiteb:default-connection-limit
Closed

TheAwiteb wants to merge 1 commit into
nostrdevkit:masterfrom
TheAwiteb:default-connection-limit

Conversation

@TheAwiteb

Copy link
Copy Markdown
Member

Refs: #1460

Checklist

  • I followed the contribution guidelines
  • I updated the relevant CHANGELOG.md (if applicable)
  • I understand and can explain all code in this PR

@TheAwiteb
TheAwiteb requested a review from yukibtc as a code owner August 22, 2026 09:38
@TheAwiteb
TheAwiteb force-pushed the default-connection-limit branch from 5f09677 to b477c6c Compare August 22, 2026 09:45
@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yukibtc

yukibtc commented Sep 19, 2026

Copy link
Copy Markdown
Member

I did a similar change at 29669c1, but then has been reverted at ca343ab

I think relays should set explicitly a max connections value, and we shouldn't default to an arbitrary value (which is quite low for who use this in production).

@yukibtc yukibtc closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants