Skip to content

fix: narrow comment firewall to paragraph workarounds - #406

Merged
norvalbv merged 1 commit into
mainfrom
codex/comment-firewall-paragraphs-v2
Aug 20, 2026
Merged

fix: narrow comment firewall to paragraph workarounds#406
norvalbv merged 1 commit into
mainfrom
codex/comment-firewall-paragraphs-v2

Conversation

@norvalbv

Copy link
Copy Markdown
Owner

Narrows #403 to the failure mode Bun/RoboBun actually targets.

  • challenge only standalone paragraphs when the staged change contributes 3+ non-structural comment lines
  • group adjacent line comments and adjacent one-line block comments without merging separate multi-line blocks
  • treat multiline block explanations opened after code or closed before structural punctuation/JSX closers as reviewable, while comments followed by executable text remain inline
  • pass one/two-line staged changes, inline comments, untouched comments, deletions, and pure renames
  • store rationale metadata in Git-local state with pre-change-blob migration, per-worktree ownership, conflict detection, CAS pruning, shared review reads, and private review writes
  • bound semantic review to one 200-finding/120k-character batch; overflow exits deterministically
  • allow no content-keyword bypasses

Prior art: oven-sh/bun#37948 and oven-sh/bun#39166.

Validation: 58 focused tests; typecheck, lint, format, build, and benchmark registry checks. Full suite: 3925 passed; one unrelated process-reaping timing fixture failed under full load and passed immediately alone.

AI review bypass explicitly authorized by the user after independent correctness, completeness, and duplicate/clone agent reviews passed; the Claude CLI weekly quota was exhausted.

Narrows #403 to the failure mode Bun/RoboBun actually targets.

- challenge only standalone paragraphs when the staged change contributes 3+ non-structural comment lines
- group adjacent line comments and adjacent one-line block comments without merging separate multi-line blocks
- treat multiline block explanations opened after code or closed before structural punctuation/JSX closers as reviewable, while comments followed by executable text remain inline
- pass one/two-line staged changes, inline comments, untouched comments, deletions, and pure renames
- store rationale metadata in Git-local state with pre-change-blob migration, per-worktree ownership, conflict detection, CAS pruning, shared review reads, and private review writes
- bound semantic review to one 200-finding/120k-character batch; overflow exits deterministically
- allow no content-keyword bypasses

Prior art: oven-sh/bun#37948 and oven-sh/bun#39166.

Validation: 58 focused tests; typecheck, lint, format, build, and benchmark registry checks. Full suite: 3925 passed; one unrelated process-reaping timing fixture failed under full load and passed immediately alone.

AI review bypass explicitly authorized by the user after independent correctness, completeness, and duplicate/clone agent reviews passed; the Claude CLI weekly quota was exhausted.
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@norvalbv, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 23a6621a-93ab-4b17-bb55-d04ed60ea429

📥 Commits

Reviewing files that changed from the base of the PR and between ba3cde3 and 3b6f3ec.

⛔ Files ignored due to path filters (9)
  • dist/README.md is excluded by !**/dist/**
  • dist/cli/lib/install/gitignore-cache.mjs is excluded by !**/dist/**
  • dist/gate-engine/comment-firewall/cli.mjs is excluded by !**/dist/**
  • dist/gate-engine/comment-firewall/detect.mjs is excluded by !**/dist/**
  • dist/gate-engine/comment-firewall/gate.mjs is excluded by !**/dist/**
  • dist/gate-engine/comment-firewall/judge.mjs is excluded by !**/dist/**
  • dist/gate-engine/comment-firewall/rationales.mjs is excluded by !**/dist/**
  • docs/benchmarks/assets/dashboard-dark.svg is excluded by !**/*.svg
  • docs/benchmarks/assets/dashboard-light.svg is excluded by !**/*.svg
📒 Files selected for processing (20)
  • .devkit/comment-firewall-rationales.json
  • README.md
  • cli/__tests__/gitignore-cache.test.mts
  • cli/lib/install/gitignore-cache.mts
  • docs/benchmarks/README.md
  • docs/benchmarks/catalog.json
  • docs/decisions/INDEX.md
  • docs/decisions/agent-comment-firewall.md
  • docs/troubleshooting.md
  • gate-engine/comment-firewall/__tests__/detect.test.mts
  • gate-engine/comment-firewall/__tests__/gate.test.mts
  • gate-engine/comment-firewall/__tests__/judge.test.mts
  • gate-engine/comment-firewall/__tests__/rationales.test.mts
  • gate-engine/comment-firewall/cli.mts
  • gate-engine/comment-firewall/detect.mts
  • gate-engine/comment-firewall/eval/run.mts
  • gate-engine/comment-firewall/gate.mts
  • gate-engine/comment-firewall/judge.mts
  • gate-engine/comment-firewall/rationales.mts
  • gate-engine/comment-firewall/types.mts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@norvalbv
norvalbv merged commit e69bb6a into main Aug 20, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant