fix(review): resolve checklist assets across providers (sc-1397) - #376
Merged
Conversation
## Summary - construct the template-literal fixture from string fragments - preserve the exact tested fixture bytes - restore a clean full-repository Biome gate on origin/main ## Root cause PR #370 added a deliberately literal `${sideEffect()}` fixture inside a single-quoted string. Biome correctly flags that representation as noTemplateCurlyInString, and PR #371 made warnings fatal, so every unrelated devkit ship became blocked. ## Validation - focused diff-focus Vitest: 30 passed - Biome check for the changed file: clean - matcher preflight: 0 new candidates - commit guard: PASS - GitNexus: exercised review-cache path is high reach, but production code and fixture value are unchanged Tracks autonomous report 741fde8b-e5ef-41d5-aaa6-df158dd673ce.
## Summary - resolve checklist scripts from the provider-projected root - keep prompts, Bash allowlists, retries, and identities on the same root - make the correctness skill and reviewer brief portable across Codex, Claude, and Cursor projections - extract cascade and asset resolution helpers to respect the size ratchet - add regression coverage for provider-specific checklist resolution ## Root cause The correctness review runtime and generated assets assumed a .claude projection. Consumers with the valid .agents projection could therefore invoke a nonexistent checklist path and fail with MODULE_NOT_FOUND. ## Validation - reproduced the failure shape in Frink and verified portable resolution selects .agents/skills/correctness/scripts/checklist.mjs - review orchestration: 123 tests passed - provider and asset suites: 106 tests passed - full review cluster: 663 tests passed before the behavior-preserving extraction - correctness review: all four lenses passed - Biome, ESLint, git diff check, and size gate passed - matcher preflight: 0 candidates; commit-guard passed ## Shared checkout note The shared checkout TypeScript run is blocked only by unrelated concurrent duplicate imports in setup-manifest.mts and setup-runtime.mts. The isolated ship excludes those changes. ## Dependency Stacked on #374, which fixes the pre-existing origin/main Biome warning that otherwise blocks every devkit ship.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
norvalbv
changed the base branch from
codex/fix-main-biome-diff-focus-fixture
to
main
August 9, 2026 20:50
norvalbv
added a commit
that referenced
this pull request
Aug 10, 2026
* fix(guard-size): scope pull-request CI to the PR diff (sc-1539) ## Summary - make pull-request size checks evaluate only files changed from the exact GitHub base commit - keep push-main, manual, and legacy-baseline audits whole-tree - resolve pull-request scope only for the gate command - share Git prefix resolution across PR diff selection and size preflight - add regressions for inherited line debt, changed growth, inherited/legacy disable debt, stale bases, and freeze isolation ## Root cause A pull-request checkout has a clean index, so guard-size fell into its whole-tree audit path. Pre-existing oversized files inherited from main were therefore blamed on unrelated PRs. ## Impact Required PR checks now fail only when the PR adds or worsens per-file size debt. Main-branch pushes still report inherited repository drift, legacy disable baselines still require migration, and non-gate commands are isolated from PR-only environment state. ## Validation - focused ratchet suites: 58 passed - Biome lint: passed - structure lint: passed - TypeScript typecheck: passed - build: passed - exact PR #376 base/head reproduction: whole-tree audit failed as before; PR-base scope passed - GitNexus staged audit: LOW risk, zero affected flows - duplication matcher and commit-guard: passed - full suite reached a pre-existing childless Vitest-parent hang; recurrence report 4c791856-dea7-4883-b460-caba479c90b3 Story: sc-1539 Autonomous report: 6f6fb84b-8fc5-484f-9d7e-50038de4b6e1 * fix(guard-size): preserve leading whitespace in git prefixes
Merged
norvalbv
added a commit
that referenced
this pull request
Aug 10, 2026
Bump 0.50.0 -> 0.51.0 and rebuild dist from a clean origin/main worktree (f817b75). Minor, not patch: two feature PRs landed since 0.50.0 — sentry-additive restages that keep earned verdicts plus a sentry judge cache (#370), and the opt-in priorArtGate deny-once step-0 ordering component (#382). The rest of the range is fixes (#371-#383). The rebuild also picks up two dist modules that git had never seen. dist/ is gitignored on working branches by design, so gate-engine/review/cascade/ consumer-assets.mjs and reviewer.mjs — the compiled output of the #376 checklist-asset refactor — existed only on disk. They are force-added here, which is exactly the path `devkit release` takes for ignored dist output. Without them the shipped runtime.mjs would import a module absent from the tag. Release smoke checks ran: built bin reports 0.51.0, dist/package.json agrees, and dist/cli/lib/ship/ship-branch.sh still wires ship_read_stdin_body (the sc-1419 stdin-hang fix survived the build). Gates bypassed at the maintainer's request (--no-verify); the range was already reviewed on its constituent PRs. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The correctness review runtime and generated assets assumed a .claude projection. Consumers with the valid .agents projection could therefore invoke a nonexistent checklist path and fail with MODULE_NOT_FOUND.
Validation
Shared checkout note
The shared checkout TypeScript run is blocked only by unrelated concurrent duplicate imports in setup-manifest.mts and setup-runtime.mts. The isolated ship excludes those changes.
Dependency
Stacked on #374, which fixes the pre-existing origin/main Biome warning that otherwise blocks every devkit ship.