Skip to content

fix(guard-size): preview base branch ceilings (sc-1494) - #375

Merged
norvalbv merged 1 commit into
mainfrom
codex/sc-1494-base-size-preflight
Aug 9, 2026
Merged

fix(guard-size): preview base branch ceilings (sc-1494)#375
norvalbv merged 1 commit into
mainfrom
codex/sc-1494-base-size-preflight

Conversation

@norvalbv

@norvalbv norvalbv commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • read the raw-line baseline from the exact ship base before creating a worktree
  • print current lines, effective ceiling, headroom, and working-tree/base drift
  • share authoritative size policy and mirror gate semantics for shipped baselines, skipped directories, and disabled caps
  • distinguish proven violations from unavailable preview reads, which defer to the authoritative gate
  • run the preview from the repository root for both new ships and PR reships
  • document the standalone command and add focused unit plus ship integration regressions
  • repair the pre-existing PR feat(review): sentry-additive restages keep earned verdicts, sentry judge gets a cache #370 test fixture encoding that made main fail Biome, without changing its value

Root cause

The authoritative guard runs in the ship worktree, where the baseline comes from the selected base. The shared checkout could expose a different size-lines baseline, so contributors could not see the real cap until after the expensive gate chain started.

Validation

  • clean detached origin/main build: bun run build
  • Story #1494 focused regressions: 9 passed
  • diff-focus prerequisite regression: 30 passed
  • base-aware preflight against origin/main: all changed source/test files within their effective ceilings
  • duplication guard: PASS
  • GitNexus scoped Story #1494 change audit: LOW risk, zero affected processes

Story: sc-1494
Autonomous report: 20dc0667-a65d-4cf8-9284-09080bc91ff7

## Summary
- read the raw-line baseline from the exact ship base before creating a worktree
- print current lines, effective ceiling, headroom, and working-tree/base drift
- share authoritative size policy and mirror gate semantics for shipped baselines, skipped directories, and disabled caps
- distinguish proven violations from unavailable preview reads, which defer to the authoritative gate
- run the preview from the repository root for both new ships and PR reships
- document the standalone command and add focused unit plus ship integration regressions
- repair the pre-existing PR #370 test fixture encoding that made main fail Biome, without changing its value

## Root cause
The authoritative guard runs in the ship worktree, where the baseline comes from the selected base. The shared checkout could expose a different size-lines baseline, so contributors could not see the real cap until after the expensive gate chain started.

## Validation
- clean detached origin/main build: bun run build
- Story #1494 focused regressions: 9 passed
- diff-focus prerequisite regression: 30 passed
- base-aware preflight against origin/main: all changed source/test files within their effective ceilings
- duplication guard: PASS
- GitNexus scoped Story #1494 change audit: LOW risk, zero affected processes

Story: sc-1494
Autonomous report: 20dc0667-a65d-4cf8-9284-09080bc91ff7
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@norvalbv, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbd472d8-14a5-4e93-a999-eafa96dd9f4c

📥 Commits

Reviewing files that changed from the base of the PR and between 7a75b93 and 33515d8.

⛔ Files ignored due to path filters (7)
  • dist/cli/lib/ship/prepare-gate-worktree.sh is excluded by !**/dist/**
  • dist/cli/lib/ship/reship.sh is excluded by !**/dist/**
  • dist/cli/lib/ship/ship-branch.sh is excluded by !**/dist/**
  • dist/gate-engine/ratchets/size-disable.mjs is excluded by !**/dist/**
  • dist/gate-engine/ratchets/size-policy.mjs is excluded by !**/dist/**
  • dist/gate-engine/ratchets/size-preflight.mjs is excluded by !**/dist/**
  • dist/skills/using-devkit/SKILL.md is excluded by !**/dist/**
📒 Files selected for processing (10)
  • cli/__tests__/ship-branch.test.mts
  • cli/lib/ship/prepare-gate-worktree.sh
  • cli/lib/ship/reship.sh
  • cli/lib/ship/ship-branch.sh
  • gate-engine/judge/__tests__/diff-focus.test.mts
  • gate-engine/ratchets/__tests__/size-preflight.test.mts
  • gate-engine/ratchets/size-disable.mts
  • gate-engine/ratchets/size-policy.mts
  • gate-engine/ratchets/size-preflight.mts
  • skills/using-devkit/SKILL.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@norvalbv
norvalbv merged commit ffc2c7f into main Aug 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant