Skip to content

fix(co-occurrence): clone gate vacuous on .mts/.mjs — CODE_EXT dropped module-suffixed extensions #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norvalbv merged 1 commit into from
Aug 2, 2026
Merged

fix(co-occurrence): clone gate vacuous on .mts/.mjs — CODE_EXT dropped module-suffixed extensions #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions gate-engine/co-occurrence/__tests__/clone-detector.test.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,24 @@ describe.skipIf(!HAS_JSCPD)('clone-detector --gate exit-code contract', () => {
expect(run(['scan', '--gate', '--paths', tmp], {}).status).toBe(1);
});

it('exit 1 — a clone in .mts files blocks (regression: CODE_EXT dropped module-suffixed exts)', () => {
// devkit's own scanRoots are pure .mts; the old /\.(tsx?|jsx?)$/ filter discarded every
// jscpd hit in .mts/.mjs, so the gate reported 0 repo-wide — a silently vacuous gate.
const mts = mkdtempSync(join(tmpdir(), 'clone-mts-'));
writeFileSync(join(mts, 'a.mts'), `${SHARED}\nexport const A_ONLY = 1;\n`);
writeFileSync(join(mts, 'b.mts'), `${SHARED}\nexport const B_ONLY = 2;\n`);
expect(run(['scan', '--gate', '--paths', mts], {}).status).toBe(1);
rmSync(mts, { recursive: true, force: true });
});

it('exit 1 — a clone in .mjs files blocks (jscpd tokenizes mjs/cjs as javascript)', () => {
const mjs = mkdtempSync(join(tmpdir(), 'clone-mjs-'));
writeFileSync(join(mjs, 'a.mjs'), `${SHARED}\nexport const A_ONLY = 1;\n`);
writeFileSync(join(mjs, 'b.mjs'), `${SHARED}\nexport const B_ONLY = 2;\n`);
expect(run(['scan', '--gate', '--paths', mjs], {}).status).toBe(1);
rmSync(mjs, { recursive: true, force: true });
});

it('exit 0 — no cross-file clone (clean)', () => {
const clean = mkdtempSync(join(tmpdir(), 'clone-clean-'));
writeFileSync(join(clean, 'solo.ts'), `${SHARED}\nexport const SOLO = 1;\n`);
Expand Down
6 changes: 4 additions & 2 deletions gate-engine/co-occurrence/clone-detector.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ const DEFAULTS = {
ignore: ['**/*.test.*', '**/*.spec.*', '**/__tests__/**', '**/__mocks__/**'],
};

// jscpd auto-detects formats by extension; we keep only source code clones.
const CODE_EXT = /\.(tsx?|jsx?)$/;
// jscpd auto-detects formats by extension; we keep only source code clones. Must cover the
// module-suffixed extensions (.mts/.cts/.mjs/.cjs — jscpd tokenizes all of them): devkit's own
// scanRoots are pure .mts, so excluding them made this gate report 0 repo-wide (vacuous).
const CODE_EXT = /\.([cm]?[tj]s|[tj]sx)$/;

// jscpd bin resolution lives in the side-effect-free ./jscpd-bin.mts (shared with the prefix-cache
// config-fingerprint, which folds the SAME resolution into the cache key). Read JSCPD_BIN here (not as
Expand Down
Loading