Repository navigation
fix: only trust location fixes Normal just received - #94
Merged
Merged
Conversation
A location key could pass on an old fix: the unlock sheet trusted the system's last-known location by its wall-clock timestamp, so setting the device clock back made an hours-old fix look fresh. Simulated locations also passed. The unlock check now only reuses a fix Normal received in the last 30 seconds (measured on a monotonic clock), and rejects fixes that are stale, dated in the future, invalid or simulated. The map's grey dot still uses the last-known location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A location key could pass on an old reading: setting the device clock back made the system's last-known location look fresh, and simulated locations passed too.
The unlock check now only reuses a reading Normal received in the last 30 s, and rejects stale, future-dated, invalid or simulated ones.