Repository navigation
fix: tie key checks to the request that started them - #93
Merged
Merged
Conversation
A widget link that arrived while a key check was open could reuse that screen for a different action: Block Without Key could run the unlock, and the duration or location sheet could switch to another group. Each check now belongs to the request that opened it and restarts when a newer one arrives, and QR scans only complete the scan they validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widget links that arrive while a key check is open could reuse it for a different action, e.g. "Block Without Key" running an unlock, or the duration sheet switching groups.
Key checks now belong to the request that opened them and restart when a newer one arrives. QR scans only complete the scan they validated.
Part 1 of splitting up the Shortcuts unblock work.