Repository navigation
Conversation
Home > Status > Max Daily Limits and the daily limit editor's duplicates warning stacked their app icons in a column, because the icons had no row around them. On group and schedule cards, when the icons filled the row, the "+N" count was squeezed into an empty grey pill. SelectionIconRow now owns the row: it shows as many icons as fit, then a fixed-size "+N" tile the size of an icon, which VoiceOver reads as "N more". Every icon row uses it. Closes #140. Closes #141.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140. Closes #141.
What and why
SelectionIconRowowns the row. AViewThatFitstries the most icons first, down to none, each followed by the right "+N" for what's hidden. Group cards, schedule cards, daily limit rows, Status and the editor warning all use it.SelectionIconsViewis now just the icons, for App Select's grid.How it was tested
testStatusShowsDailyLimitIconsInOneRow: the eight-app limit on Status is one row, about one tile high, ending in "+N".testCardIconRowsKeepTheOverflowCountReadableAtTheLargestTextSize: at the largest accessibility size, the group card's "+N" tile isn't squeezed, reads "N more", and the row fits on screen.-uiTestCrowdedSelections: nine websites on the main selection, the seeded group and the seeded schedule.-uiTestSeedUsageLimit: a daily limit with eight apps.AI use
Claude Code wrote the code, the tests and this description.
Co-authored-by: Claude Code (Claude Opus 5.5)