Skip to content

fix: keep app icon rows on one line with a readable overflow count - #143

Open
ykisana wants to merge 1 commit into
mainfrom
fix/selection-icon-rows
Open

ykisana wants to merge 1 commit into
mainfrom
fix/selection-icon-rows

Conversation

@ykisana

@ykisana ykisana commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Closes #140. Closes #141.

What and why

  • Max Daily Limit Layout Only Stacks App Icons #141: Home › Status › Max Daily Limits stacked a limit's app icons in a single column, and so did the daily limit editor's "Already in another limit" warning. The icons had no row around them. They now sit on one line like everywhere else.
  • Grey rectangle appears in app groups and schedules #140: on group and schedule cards, when the icons filled the row, the "+N" count got squeezed until only its grey background was left. That was the grey rectangle.
  • New overflow count: a row now shows as many icons as fit, then a "+N" tile the size of an icon, rounded like one. It never shrinks, grows with text size, and VoiceOver reads it as "N more".
  • SelectionIconRow owns the row. A ViewThatFits tries the most icons first, down to none, each followed by the right "+N" for what's hidden. Group cards, schedule cards, daily limit rows, Status and the editor warning all use it. SelectionIconsView is now just the icons, for App Select's grid.

How it was tested

  • New UI tests:
    • testStatusShowsDailyLimitIconsInOneRow: the eight-app limit on Status is one row, about one tile high, ending in "+N".
    • testCardIconRowsKeepTheOverflowCountReadableAtTheLargestTextSize: at the largest accessibility size, the group card's "+N" tile isn't squeezed, reads "N more", and the row fits on screen.
  • New UI test seeds:
    • -uiTestCrowdedSelections: nine websites on the main selection, the seeded group and the seeded schedule.
    • -uiTestSeedUsageLimit: a daily limit with eight apps.
  • Unit tests: 916/916. UI tests: 64/64. Both on the iPhone Air iOS 27.0 simulator.
  • Screenshots before and after on an iPhone 17e (iOS 26.5) and an iPhone SE (iOS 17.5).
  • Not tested: the exact squeeze from Grey rectangle appears in app groups and schedules #140. In the simulator, apps show as blank placeholders and websites as small globe icons, so the row never gets as full as it does with real app icons. That needs a device.

AI use

Claude Code wrote the code, the tests and this description.

Co-authored-by: Claude Code (Claude Opus 5.5)

  • Touches a "Hard to reverse" area in CONTRIBUTING.md, agreed in the issue

Home > Status > Max Daily Limits and the daily limit editor's
duplicates warning stacked their app icons in a column, because the
icons had no row around them. On group and schedule cards, when the
icons filled the row, the "+N" count was squeezed into an empty grey
pill.

SelectionIconRow now owns the row: it shows as many icons as fit,
then a fixed-size "+N" tile the size of an icon, which VoiceOver reads
as "N more". Every icon row uses it.

Closes #140. Closes #141.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Max Daily Limit Layout Only Stacks App Icons Grey rectangle appears in app groups and schedules

1 participant