Repository navigation
fix: show every FAQ answer in full - #122
Merged
Merged
Conversation
Some FAQ answers were cut off with "...": the key type examples and the dumbphone answer at every text size, and at larger sizes the Shortcuts answer's subheadings and the contact email. Each answer sits in a List row that can lay out shorter than its text, so an expanded answer now takes its full height. Two UI tests open every FAQ answer, at the default and a large text size, and read the screen with on-device text recognition to check that no line ends in an ellipsis.
ykisana
force-pushed
the
fix/faq-truncation
branch
from
November 18, 2026 10:58
84fd455 to
29cc01a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Some FAQ answers were cut off with "…":
How
FAQItemnow gives the expanded answer its full height with.fixedSize(horizontal: false, vertical: true).NumberedRowandBulletRowalready do this; now it covers every answer at once.Tests
testFAQAnswersAreNotCutOffandtestFAQAnswersAreNotCutOffAtLargeTextSizesopen every FAQ answer, including the bypass guide's nested methods. They page through to the end and read the screen with on-device text recognition (Vision), failing if any line ends in "…" or "...". They find the questions through anexpandableSectionaccessibility identifier, so new FAQ entries are covered without changing the test. They only read the area between the toolbar and the tab bar, so text passing under the Close button isn't misread.