Skip to content

fix: show every FAQ answer in full - #122

Merged
ykisana merged 1 commit into
mainfrom
fix/faq-truncation
Nov 18, 2026
Merged

ykisana merged 1 commit into
mainfrom
fix/faq-truncation

Conversation

@ykisana

@ykisana ykisana commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What

Some FAQ answers were cut off with "…":

  • "What can I use as a key?": the key type examples, at every text size.
  • "Can I use Normal to make my iPhone a dumbphone…": its first and last lines, at the default size.
  • At larger text sizes: the Shortcuts answer's subheadings ("Unblock when you ar…") and the contact email ("info@normalengineer…").

How

  • Each answer sits in a List row that can lay out shorter than its text. FAQItem now gives the expanded answer its full height with .fixedSize(horizontal: false, vertical: true). NumberedRow and BulletRow already do this; now it covers every answer at once.

Tests

  • testFAQAnswersAreNotCutOff and testFAQAnswersAreNotCutOffAtLargeTextSizes open every FAQ answer, including the bypass guide's nested methods. They page through to the end and read the screen with on-device text recognition (Vision), failing if any line ends in "…" or "...". They find the questions through an expandableSection accessibility identifier, so new FAQ entries are covered without changing the test. They only read the area between the toolbar and the tab bar, so text passing under the Close button isn't misread.
  • Proved on an iPhone 17e (iOS 26.5) simulator: both pass twice in a row with the fix. Without it, they fail and list the cut-off lines, e.g. "a product barcode off a snack wra...", "Unblock when you ar...", "info@normalengineer...".
  • Also expanded every answer at both sizes on an iPhone SE (iOS 17.5) and checked the screenshots.
  • Unit tests: 883/883. UI tests: 49/49. Both on the iPhone 17e iOS 26.5 simulator.

Some FAQ answers were cut off with "...": the key type examples and
the dumbphone answer at every text size, and at larger sizes the
Shortcuts answer's subheadings and the contact email. Each answer sits
in a List row that can lay out shorter than its text, so an expanded
answer now takes its full height.

Two UI tests open every FAQ answer, at the default and a large text
size, and read the screen with on-device text recognition to check
that no line ends in an ellipsis.
@ykisana
ykisana merged commit e825298 into main Nov 18, 2026
1 check passed
@ykisana
ykisana deleted the fix/faq-truncation branch November 18, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant