Skip to content

feat: offer the Keys tab when an action needs a key - #118

Merged
ykisana merged 1 commit into
mainfrom
feat/no-key-alert
Nov 18, 2026
Merged

ykisana merged 1 commit into
mainfrom
feat/no-key-alert

Conversation

@ykisana

@ykisana ykisana commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #99.

Block buttons no longer grey out when there's no key. Tapping one shows "Add a Key First" with Not Now and Go to Keys, replacing the small footer hints on Home and Groups.

  • The check lives in KeyCheckFlow, so Home, Groups, the widget and the key-protected toggles share one alert. When the only keys belong to groups, it says group keys only unblock their own group.
  • A group can be blocked if it has its own key, since that key can unblock it. This applies to the group card, the widget and the Shortcuts Block Group action. Before, the card and Shortcuts needed a key outside groups. Block All and the toggles still do.
  • Schedules' "No Keys" screen gets a Go to Keys button.
  • The selected tab moves into NavigationCoordinator so any screen can switch tabs.

Tests

  • KeyCheckFlowTests: blocking with no keys, with only other groups' keys (for a group and for Block All), and with keys this device can't read each asks for a key. A group with its own key gets the key sheet, and that key still unblocks it.
  • NavigationCoordinatorTests: showing a tab closes Settings.
  • BlockActionsTests and AppBlockIntentPerformerTests: the Shortcuts Block Group action accepts the group's own key and rejects another group's key.
  • RecoveryUITests:
    • Block All with no keys, Schedules' No Keys screen and Settings' Block Adult Websites toggle each open the Keys tab. From Settings, the sheet closes too.
    • Block All with only group keys says group keys aren't enough. A group with its own key can be blocked.
    • Unblocking with no keys still shows the alert and leaves apps blocked.
  • Unit tests: 895/895. UI tests: 52/52. Both on the iPhone Air iOS 27.0 simulator.

Block buttons no longer grey out without a key. Tapping one shows
"Add a Key First" with Not Now and Go to Keys, replacing the footer
hints on Home and Groups. The check lives in KeyCheckFlow, so every
key-checked action shares it. A group can be blocked when it has its
own key, from its card, the widget or Shortcuts, since that key can
unblock it. Block All still needs a key outside groups.

Closes #99.
@ykisana
ykisana merged commit 829ca97 into main Nov 18, 2026
1 check passed
@ykisana
ykisana deleted the feat/no-key-alert branch November 18, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better onboarding guidance when no keys

1 participant