Repository navigation
feat: offer the Keys tab when an action needs a key - #118
Merged
Merged
Conversation
ykisana
force-pushed
the
feat/no-key-alert
branch
from
November 18, 2026 06:05
07bbd15 to
4a04fc2
Compare
Block buttons no longer grey out without a key. Tapping one shows "Add a Key First" with Not Now and Go to Keys, replacing the footer hints on Home and Groups. The check lives in KeyCheckFlow, so every key-checked action shares it. A group can be blocked when it has its own key, from its card, the widget or Shortcuts, since that key can unblock it. Block All still needs a key outside groups. Closes #99.
ykisana
force-pushed
the
feat/no-key-alert
branch
from
November 18, 2026 08:27
4a04fc2 to
8f6f54a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99.
Block buttons no longer grey out when there's no key. Tapping one shows "Add a Key First" with Not Now and Go to Keys, replacing the small footer hints on Home and Groups.
KeyCheckFlow, so Home, Groups, the widget and the key-protected toggles share one alert. When the only keys belong to groups, it says group keys only unblock their own group.NavigationCoordinatorso any screen can switch tabs.Tests
KeyCheckFlowTests: blocking with no keys, with only other groups' keys (for a group and for Block All), and with keys this device can't read each asks for a key. A group with its own key gets the key sheet, and that key still unblocks it.NavigationCoordinatorTests: showing a tab closes Settings.BlockActionsTestsandAppBlockIntentPerformerTests: the Shortcuts Block Group action accepts the group's own key and rejects another group's key.RecoveryUITests: