Repository navigation
Keepalive: clear a stale implicit skip reason when a request sets a TTL - #29
Merged
Merged
Conversation
…s a TTL requestSent committed a snapshot that still carried the previous turn's implicit skip reason, so the server dropped the primary messages it had just stored and the first ping after a learned alias went out unaligned.
|
cris005
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 6 of the savings ledger stack, which replaces #28.
requestSentcommitted a snapshot that still carried the previous turn'simplicitskip reason. The server then dropped the primary messages it had just stored, so the first ping after a learned alias went out without matching the last request.Wiring the ledger exposed this, but the fix stands on its own: two lines in the engine and two tests.
Stack created with GitHub Stacks CLI • Give Feedback 💬