Repository navigation
machine: Fretwire pickups, wiring and bodies - #24
Merged
Merged
Conversation
nooga
added this pull request to stack #25
October 16, 2026 21:38
Guitar and bass now share a bridge, a modal body and the pickup wiring across their strings: two pickups (single coil, P-90, humbucker, split) with selector, height and out-of-phase; a coil/cable/tone-pot circuit; SOLID/SEMI/HOLLOW/ACOUSTIC bodies with AIR, PIEZO and sympathetic strings. COUPLE 0 reproduces the previous sound. New presets fitted against Karoryfer's Emily and Growlybass, the rest re-voiced. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nooga
force-pushed
the
claude/fretwire-bodies
branch
from
October 16, 2026 21:49
4997598 to
9c4ef87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23 (Hammerwork Grand + Skinwork Kit, which adds the shared-state host features this uses). Merge #23 first; this then retargets to master.
What
Fretwire Guitar and Fretwire Bass get a full electric/acoustic instrument around the waveguide strings (docs/41 §Fretwire: pickups, wiring and bodies):
shared!/voice-level!): SOLID/SEMI/HOLLOW/ACOUSTIC (bass SOLID/HOLLOW/ACOUSTIC), COUPLE, AIR radiation, PIEZO, SYMP sympathetic strings.Compatibility
Control ids kept (old TONE/RES are now RESO/PEAK). COUPLE 0 nulls against the old Fretwire at −111…−126 dB; the default SOLID body changes old songs by a −18…−30 dB residual (CHANGELOG notes it).
Presets
23 factory presets: guitar default, fingers, bridge, slide, palm-mute, funk, jazz, twin-humbucker, p90-crunch, semi-hollow, out-of-phase, acoustic; bass default, pick, palm-mute, fingers-bridge, flatwound, pop, slap, jazz-both, p-bass, hollow, acoustic. twin-humbucker and jazz-both are fitted against Karoryfer Emily / Growlybass (spectral error 11.0→7.5 dB and 12.8→7.8 dB). Levels calibrated on a DI riff render.
Testing
zig build testpasses.zig build bench -- --all --check --no-sheets: guitar/bass/grand/kit bit-exact (goldens re-recorded for guitar/bass). The run exits 1 only because shift2/resonator2/buffer2/phaser2 have no goldens — pre-existing on master.🤖 Generated with Claude Code