Repository navigation
Musical typing, piano roll octave echoes and scale marks, separate STOP/PLAY - #22
Merged
Merged
Conversation
…docs/40) KEYS in the transport bar plays the selected track from the computer keyboard: PIANO (one chromatic row), GRID (Push-style fourths, in key with a scale) or CHORD (in-key chords on the bottom row under a melody). With KEYS on, REC records into the open clip or a new take clip, growing by bars and layering across loop passes, one undo step per pass. Held notes carry the KEYS velocity (Engine.holdNoteVel); claimed keys stand the panes' unmodified shortcuts down. The piano roll lights a pressed note in every octave on keys and grid, shows the note a click would add (with octave outlines) in DRAW mode, and marks a picked scale: key stripes, greyed out-of-key keys, tinted rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Musical typing (docs/40). KEYS in the transport bar plays the selected track from the computer keyboard. There are three layouts:
Zrow under a melody on theA/Qrows; keys1–6pick the chord type.Octave is
-=, velocity[](on PIANO alsoZX/CV). Held notes use the KEYS velocity (Engine.holdNoteVel). While KEYS is on, its keys switch off the panes' unmodified shortcuts on those keys; ⌘ combinations, text fields and menus still get them.Recording. With KEYS on, REC records into the clip open in the piano roll, or into a new "Take" clip. The clip grows by bars. Loop passes layer on top of each other, with one undo step per pass. Held notes draw growing, outlined in red.
Piano roll. A pressed key lights faintly in every octave on the keys and the grid. In DRAW mode (or with ⌘ held) a ghost shows the note a click would add, with outlines in its other octaves. A picked scale stripes its keys (solid on the root), greys the keys outside it, and tints its rows in the track color.
Transport. STOP and PLAY are separate buttons. STOP pressed again while stopped returns to the loop start, or to the song start when the loop is off.
Test plan
zig build test: new unit tests for the layouts, chords, scale degrees, key claims, the velocity ladder, and the take recorder (presses, releases, loop-wrap split)🤖 Generated with Claude Code