Repository navigation
Wait on the page's own changes instead of polling, in the menus', overlays' and dialogs' specs - #157
Merged
Merged
Conversation
…ents' specs DomChangeFixture.untilAsync runs a check again on each mutation, focus or pointer move, scroll and image load or failure, bounded like every poll; the poll and test limits check holds it to the shared bound. Agent: DEV1 (developer) Agent-Model: Anthropic Opus 5.5, Medium
…lays' and dialogs' specs Agent: DEV1 (developer) Agent-Model: Anthropic Opus 5.5, Medium
A ChangeSignalFixture carries the shared bound and the check's own failure for every wait on a change, and DomChangeFixture is built on it, so the frame request in the configuration table spec waits on one, with the shared bound and message, rather than on an unbounded promise. A check that gives a promise fails the wait at once. The completion list's hover checks run after the hover, so they are plain expects. Agent: DEV1 (developer) Agent-Model: Anthropic Opus 5.5, Medium
The browser's accessibility tree is read through a server command and catches up with the page after its changes, so no page signal says when a description is current, and a wait on a change takes no async check. These ten checks poll with vi.waitFor and the shared bound again. Agent: DEV1 (developer) Agent-Model: Anthropic Opus 5.5, Medium
The overlay reports a lost anchor from a ResizeObserver callback, which comes after the style change and changes nothing on the page, so a wait on the page's changes never checks again. The spec fires a change signal on each report and waits on that. Agent: DEV1 (developer) Agent-Model: Anthropic Opus 5.5, Medium
rostislavrotaru
marked this pull request as ready for review
November 15, 2026 03:13
rostislavrotaru
commented
Nov 15, 2026
rostislavrotaru
left a comment
rostislavrotaru
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed: #157 at 8f34abc
Verdict: Approve
Findings: 0 Should fix, 0 Low, as line comments
Why it's right: each of the 125 vi.waitFor polls becomes a DomChangeFixture wait on what the component writes, with every spec's tests and expects kept; the lost-anchor wait listens to the overlay's own originLost, since a ResizeObserver report changes nothing on the page, and the ten accessibility-tree reads stay bounded polls. CI is green at this head on two runs.
Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #145
The second PR for #145, after #156, whose
DomChangeFixtureandChangeSignalFixtureit uses. It moves the menus', menu bar's, popover's, tooltip's and dialog's specs off polling.Changed
vi.waitForcalls now go throughDomChangeFixture.untilAsync, unchanged otherwise. The files aretests/app/components/menu/*(context menu trigger, menu group and its action, menu item and its chevron, menu trigger),menu-bar/*,popover/popover-trigger.directive.spec.ts,tooltip/tooltip.directive.spec.ts,dialog/*,tests/app/services/dialog.service.spec.tsandtests/app/services/anchored-overlay.spec.ts.anchored-overlay.spec.ts's lost-anchor test waits on the overlay's ownoriginLostthrough aChangeSignalFixture: the overlay reports it from aResizeObservercallback, which changes nothing on the page.Still polling
vi.waitForwithHangLimitFixture.wait. The tree is read through a server command and catches up with the page after its changes, so no page signal says when it is current, and a wait on a change takes no async check. The README's list of remaining polls, in the last PR for Wait on the code's own events instead of polling in the specs #145, names them.Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium