Skip to content

Move the kit to context 0.0.8 and take the timing median from context.testing - #155

Merged
rostislavrotaru merged 2 commits into
mainfrom
dev1/153-context-0.0.8
Nov 15, 2026
Merged

rostislavrotaru merged 2 commits into
mainfrom
dev1/153-context-0.0.8

Conversation

@rostislavrotaru

@rostislavrotaru rostislavrotaru commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

The kit moves to context 0.0.8, and the timing check takes its median from @noldova/context.testing instead of keeping its own copy.

Changes

  • src/noldova.ui.components.angular/package.json:
    • the peer ranges of @noldova/context.core and @noldova/context.exceptions move from >=0.0.7 <0.1.0 to >=0.0.8 <0.1.0;
    • their development pins move from 0.0.7 to 0.0.8;
    • @noldova/context.testing 0.0.8 is a new development dependency.
  • src/noldova.ui.components.angular.docs/package.json: the pins of core and exceptions move from 0.0.7 to 0.0.8.
  • src/noldova.ui.components.angular/scripts/angular/angular-test-timing.ts: the static median is gone. The check takes each test's median and each file's median of them from TestTimingCheck.median, which returns undefined for no values; the check keeps its old 0 for that case.
  • package-lock.json: refreshed with npm install --package-lock-only --ignore-scripts --no-audit --no-fund. It moves:
    • @noldova/context.core and @noldova/context.exceptions, 0.0.7 to 0.0.8;
    • @noldova/context.testing, @noldova/context.collections and @noldova/context.text, new at 0.0.8, as development packages, since context.testing 0.0.8 depends on them.
    • No other entry moved.
  • README.md: the timing check's section names where its median comes from.
  • src/noldova.ui.components.angular/README.md: the peer range it gives is >=0.0.8 <0.1.0.

Linked issue

Closes #153

This replaces the automated #152, which moves the same pins and lock entries for #151; once this merges, #152 and #151 close.

Testing

  • CI: the whole suite and the builds, with the moved lock.
  • Timing check: CI doesn't run npm run test:timing, so it ran on a Linux test machine at 6560a58, with the evidence in this PR's comments: its own check on small reports holds in all 8 cases. Its runs found 48 of the kit's spec files over, where Bring each spec file's median test under 100 ms #148 lists 43 on Linux; the comment names the files that differ.

Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium

….testing

The kit's pins of @noldova/context.core and @noldova/context.exceptions
move from 0.0.7 to 0.0.8, and its peer ranges to >=0.0.8 <0.1.0.
@noldova/context.testing 0.0.8 becomes a development dependency, and
the timing check takes its medians from TestTimingCheck.median instead
of its own copy.

The lock was refreshed with npm install --package-lock-only
--ignore-scripts --no-audit --no-fund: core and exceptions move to
0.0.8, and context.testing, context.collections and context.text come
in at 0.0.8 as development packages; no other entry moved.

Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium
@rostislavrotaru rostislavrotaru self-assigned this Nov 15, 2026
@rostislavrotaru

Copy link
Copy Markdown
Contributor Author

npm run test:timing for the kit at 6560a58, on a Linux test machine, after npm ci and npm run build:

  • The timing check's own check on small reports holds in all 8 cases, among them "each test's time is its median over the runs, not its slowest run", which now runs on TestTimingCheck.median.
  • Its three runs of the kit's specs then timed 382 spec files and found 48 over the 100 ms median test with its margin, so the check exited 1. Before this change, three runs of the same check gave 27, 43 and 53 over, so the count is within that spread. Those files are the timing check's own open findings, not something this change moves.

Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium

@rostislavrotaru
rostislavrotaru marked this pull request as ready for review November 15, 2026 00:41

@rostislavrotaru rostislavrotaru left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: #155 at 6560a58
Verdict: Changes needed
Findings: 1 Should fix, 2 Low, as line comments
Why it's right: the kit moves its context pins to 0.0.8 with peers >=0.0.8 <0.1.0, the lock moves only the five named packages, and the timing check's median comes from context.testing with the same results; the package README still states the old range.

Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High

Comment thread README.md Resolved
Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium
@rostislavrotaru

rostislavrotaru commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Correction to the timing comment above: the earlier 27, 43 and 53 were one run each on a Linux, a Windows and a macOS test machine, not three runs on one machine. The comparable count is Linux's 43, which #148 lists, against 48 at 6560a58.

The Linux files that differ from #148's Linux column:

Each new one but code-block-run.component.spec.ts, at 214.5 ms and over on Windows in #148, is within 40% of the 100 ms budget, and this change only moves the median's source, so a test's time doesn't depend on it. The two files not on #148's list belong on it.

Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium

@rostislavrotaru rostislavrotaru left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: #155 at 560b53a
Verdict: Approve
Findings: 0 Should fix, 0 Low, as line comments
Why it's right: the kit takes context 0.0.8 with peers >=0.0.8 <0.1.0, its package README says the same, the lock moves only the five named packages, and the timing check's median comes from context.testing with the same results; it replaces #152.

Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High

@rostislavrotaru
rostislavrotaru merged commit b704769 into main Nov 15, 2026
19 checks passed
@rostislavrotaru
rostislavrotaru deleted the dev1/153-context-0.0.8 branch November 15, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the kit to context 0.0.8 and take the timing check's median from context.testing

1 participant