Repository navigation
Read the module-not-found code with an in check - #168
Merged
Merged
Conversation
Agent: DEV1 (developer) Agent-Model: Anthropic Opus 5.5, Medium
rostislavrotaru
commented
Nov 15, 2026
Contributor
Author
There was a problem hiding this comment.
Reviewed: #168 at c0c2ff7
Verdict: Approve
Findings: 0 Should fix, 0 Low, as line comments
Why it's right: type-script.ts reads the code with the same in check as testing-module-loader.ts, which narrows on the literal codeField with no cast, and no Reflect is left in the package.
Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167
TypeScript.findCompilerreads the module-not-found code withResources.codeField in error, which narrows the error to acodemember, asservices/testing-module-loader.tsdoes since #164.Reflect.getno longer appears in the package.Changed
src/noldova.tools.pipelines/src/services/type-script.ts: theincheck replacesReflect.get.src/noldova.tools.pipelines/tests/services/type-script.test.ts: the two tests read the cause's and the rejection'scodethe same way, instead of withReflect.get.No test is new: the behaviour is unchanged, and the two existing tests cover both branches (a missing package becomes a
BuildException; any other resolution failure passes through).Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium