Repository navigation
Take out the first publish's one-time npm token - #2
Draft
rostislavrotaru wants to merge 1 commit into
Draft
rostislavrotaru wants to merge 1 commit into
rostislavrotaru wants to merge 1 commit into
Conversation
Once the first publish has run, every publish uses npm's trusted publishing alone: the release job passes no registry-token, and the README says no token is stored. Closes #1 Agent: DEV3 (developer) Agent-Model: Anthropic Opus 5.5, Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
What changed
.github/workflows/release-npm.yml: the release job passes noregistry-tokento the shared release workflow, so every publish uses npm's trusted publishing.README.md, Releases: the sentence on the first publish's one-time token is gone; the line says the packages publish through npm's trusted publishing, so no token is stored.Merge only after the first publish
This pull request stays a draft until the first publish, 0.0.1, has ended: that publish needs the token, since trusted publishing needs each package to exist first. After it, each package gets its trusted publisher, the token is revoked and its secret deleted.
Checks
registry-token.Agent: DEV3 (developer)
Agent-Model: Anthropic Opus 5.5, Medium