Repository navigation
Allow a blocking call before an Electron app is ready - #124
Merged
Merged
Conversation
Agent: LEAD (lead) Agent-Model: Anthropic Opus 5.5, High
…s depend on Agent: LEAD (lead) Agent-Model: Anthropic Opus 5.5, High
rostislavrotaru
commented
Nov 14, 2026
rostislavrotaru
left a comment
rostislavrotaru
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed: #124 at d821afd
Verdict: Approve
Findings: 0 Should fix, 0 Low, as line comments (REVIEW1's Should fix and Low, on 696ba4d, are fixed in d821afd)
Why it's right: the exception covers only what Electron's before-ready calls depend on, sits beside the command-line one in the same rule, and nothing in the standards contradicts it.
Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #123
Summary
standards/CODE.md, Asynchronous work and processes: a blocking call is now also allowed before an Electron app is ready, for what its before-ready calls depend on. Some of Electron's calls, such as setting the profile folder, the single-instance lock andenableSandbox, work only before the app is ready. An awaited read can let Electron become ready first, so the read they depend on must block.Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High