Skip to content

Keep per-class resources files for packages whose parts apps import separately - #122

Merged
rostislavrotaru merged 1 commit into
mainfrom
dev1/121-part-resources
Nov 14, 2026
Merged

rostislavrotaru merged 1 commit into
mainfrom
dev1/121-part-resources

Conversation

@rostislavrotaru

Copy link
Copy Markdown
Contributor

Summary

Only a package whose parts apps import separately keeps per-class resources files; every other package keeps its strings in its one Resources.

  • standards/stacks/TYPESCRIPT.md, Canonical values:
    • The line allowing a class's own <name>.resources.ts now applies only to a package whose parts apps import separately, such as a components library, where it lets a bundler drop the strings of parts an app doesn't import.
    • A new line says every other package, such as one that runs unbundled or that apps use as a whole, keeps all its strings in its one Resources.
    • The catalog line and the scripts' scripts/resources.ts line are unchanged.

standards/stacks/ANGULAR.md's partResources line already concerns components, so it stays. No other document in this repository or the handbook states the wider rule.

Linked issue

Closes #121

Testing

  • Tests: this repository's PR checks. The change is a document only.
  • Manual: searched this repository's and the handbook's documents for .resources.ts and <Name>Resources; only this line and the components-only line in ANGULAR.md mention per-class files.

Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium

…eparately

A class's own <name>.resources.ts only lets a bundler drop the strings of
parts an app doesn't import, so only such a package, such as a components
library, keeps them; every other package keeps all its strings in its one
Resources.

Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium
@rostislavrotaru rostislavrotaru self-assigned this Nov 14, 2026

@rostislavrotaru rostislavrotaru left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: #122 at f07b6de
Verdict: Approve
Findings: 0 Should fix, 0 Low, as line comments
Why it's right: per-class <name>.resources.ts files are now allowed only in a package whose parts apps import separately, every other package keeps its strings in its one Resources, and the catalog and scripts lines are unchanged.

Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High

@rostislavrotaru
rostislavrotaru merged commit ef25b03 into main Nov 14, 2026
2 checks passed
@rostislavrotaru
rostislavrotaru deleted the dev1/121-part-resources branch November 14, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep per-class resources files for packages whose parts apps import separately

1 participant