Repository navigation
Keep per-class resources files for packages whose parts apps import separately - #122
Merged
Merged
Conversation
…eparately A class's own <name>.resources.ts only lets a bundler drop the strings of parts an app doesn't import, so only such a package, such as a components library, keeps them; every other package keeps all its strings in its one Resources. Agent: DEV1 (developer) Agent-Model: Anthropic Opus 5.5, Medium
rostislavrotaru
commented
Nov 14, 2026
rostislavrotaru
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed: #122 at f07b6de
Verdict: Approve
Findings: 0 Should fix, 0 Low, as line comments
Why it's right: per-class <name>.resources.ts files are now allowed only in a package whose parts apps import separately, every other package keeps its strings in its one Resources, and the catalog and scripts lines are unchanged.
Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only a package whose parts apps import separately keeps per-class resources files; every other package keeps its strings in its one
Resources.standards/stacks/TYPESCRIPT.md, Canonical values:<name>.resources.tsnow applies only to a package whose parts apps import separately, such as a components library, where it lets a bundler drop the strings of parts an app doesn't import.Resources.scripts/resources.tsline are unchanged.standards/stacks/ANGULAR.md'spartResourcesline already concerns components, so it stays. No other document in this repository or the handbook states the wider rule.Linked issue
Closes #121
Testing
.resources.tsand<Name>Resources; only this line and the components-only line inANGULAR.mdmention per-class files.Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium