Repository navigation
Keep a repository's root scripts' strings in one scripts/resources.ts - #120
Merged
Merged
Conversation
The root scripts read their strings and named numbers from one Resources class, as a package does; it imports nothing, since the scripts run before the install, and writes an empty string as ''. A package's own build script keeps reading its package's Resources. Agent: DEV1 (developer) Agent-Model: Anthropic Opus 5.5, Medium
rostislavrotaru
commented
Nov 14, 2026
rostislavrotaru
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed: #120 at bc3c7fa
Verdict: Approve
Findings: 0 Should fix, 0 Low, as line comments
Why it's right: the scripts' rule now names one import-free scripts/resources.ts in the package Resources form, the parallel-classes line lists it, a package's own build script keeps reading its package's Resources, and "Scripts have no tests" is unchanged.
Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A repository's root scripts keep their strings and named numbers in one
scripts/resources.ts, as a package keeps its own inResources.standards/stacks/TYPESCRIPT.md, Canonical values:scripts/keep their strings and named numbers in onescripts/resources.ts, oneResourcesclass of the package form.''.Resources, not from the scripts' file.No other document in this repository or the handbook states the old rule.
Linked issue
Closes #119
Testing
Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium