Skip to content

Keep a repository's root scripts' strings in one scripts/resources.ts - #120

Merged
rostislavrotaru merged 1 commit into
mainfrom
dev1/119-scripts-resources
Nov 14, 2026
Merged

rostislavrotaru merged 1 commit into
mainfrom
dev1/119-scripts-resources

Conversation

@rostislavrotaru

Copy link
Copy Markdown
Contributor

Summary

A repository's root scripts keep their strings and named numbers in one scripts/resources.ts, as a package keeps its own in Resources.

  • standards/stacks/TYPESCRIPT.md, Canonical values:
    • The line "Scripts keep their constants on their owning class, without a shared scripts resources file" is replaced. A repository's root scripts/ keep their strings and named numbers in one scripts/resources.ts, one Resources class of the package form.
    • The file imports nothing, since the scripts run before the install, so it writes an empty string as ''.
    • A package's own build script, beside the package, reads from that package's Resources, not from the scripts' file.
    • The line on resource directories and parallel classes names the scripts' file beside a catalog's class.
  • "Scripts have no tests and no coverage requirement", under Scripts and Node, stays as it is.

No other document in this repository or the handbook states the old rule.

Linked issue

Closes #119

Testing

  • Tests: this repository's PR checks. The change is a document only.
  • Manual: searched this repository's and the handbook's documents for the old rule; the replaced line was its only statement.

Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium

The root scripts read their strings and named numbers from one Resources
class, as a package does; it imports nothing, since the scripts run before the
install, and writes an empty string as ''. A package's own build script keeps
reading its package's Resources.

Agent: DEV1 (developer)
Agent-Model: Anthropic Opus 5.5, Medium
@rostislavrotaru rostislavrotaru self-assigned this Nov 14, 2026

@rostislavrotaru rostislavrotaru left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: #120 at bc3c7fa
Verdict: Approve
Findings: 0 Should fix, 0 Low, as line comments
Why it's right: the scripts' rule now names one import-free scripts/resources.ts in the package Resources form, the parallel-classes line lists it, a package's own build script keeps reading its package's Resources, and "Scripts have no tests" is unchanged.

Agent: LEAD (lead)
Agent-Model: Anthropic Opus 5.5, High

@rostislavrotaru
rostislavrotaru merged commit 1cf6a8f into main Nov 14, 2026
2 checks passed
@rostislavrotaru
rostislavrotaru deleted the dev1/119-scripts-resources branch November 14, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scripts keep their constants in one scripts/resources.ts

1 participant