feat: add get_number_from_path#98
Open
jp4g wants to merge 1 commit into
Open
Conversation
Mirrors the existing pub `get_string_from_path`: walks a chain of object keys and returns `Option<u64>` from the terminal key. Fills the gap where, with the root JSON being an object, numeric extraction at a root-level key has no public entry point (the underlying `get_number` is `pub(crate)`, and `get_number_from_array` only applies when the root is an array). No breaking changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pub fn get_number_from_pathmirroring the existingget_string_from_path.Motivation
When the root JSON is an object, there is currently no public path to extract a numeric value at a root-level (or nested) key:
get_number/get_number_uncheckedarepub(crate).get_number_from_array/_uncheckedarepubbut only apply when the root is an array.get_value_from_pathreturns aJSONValuewithpub(crate)fields, so the bytes are unreachable anyway.This PR closes that gap with the smallest possible change: one new public function, symmetric with
get_string_from_path.Test plan
nargo test).let n = json.get_number_from_path([key_vec(\"exp\")]).unwrap();resolves and returns au64for a top-level numeric key.